sllin: Don't fiddle with netdev queue and skb in slave receive mode

[linux-lin.git] / sllin / sllin.c

diff --git a/sllin/sllin.c b/sllin/sllin.c
index e05564cf33598d7839ece2a71c0b68cc1a0bc803..c922b848b7706d2e0929ac2d23889beea6e35c8e 100644 (file)
--- a/sllin/sllin.c
+++ b/sllin/sllin.c
@@ -768,10 +768,9 @@ static void sllin_slave_receive_buf(struct tty_struct *tty,
 
                        sl->lin_state = SLSTATE_ID_RECEIVED;
                        /* Is the length of data set in frame cache? */
-                       if (sce->frame_fl & LIN_CACHE_RESPONSE) {
+                       if (sce->dlc > 0) {
                                sl->rx_expect += sce->dlc + 1; /* + checksum */
                                sl->rx_len_unknown = false;
-                               set_bit(SLF_MSGEVENT, &sl->flags);
                                wake_up(&sl->kwt_wq);
                        } else {
                                sl->rx_expect += SLLIN_DATA_MAX + 1; /* + checksum */
@@ -950,7 +949,16 @@ static enum hrtimer_restart sllin_rx_timeout_handler(struct hrtimer *hrtimer)
 {
        struct sllin *sl = container_of(hrtimer, struct sllin, rx_timer);
 
-       if (sl->lin_master) {
+       /*
+        * Signal timeout when:
+        * master: We did not receive as much characters as expected
+        * slave: * we did not receive any data bytes at all
+        *        * we know the length and didn't receive enough
+        */
+       if ((sl->lin_master) ||
+                       (sl->rx_cnt <= SLLIN_BUFF_DATA) ||
+                       ((!sl->rx_len_unknown) &&
+                       (sl->rx_cnt < sl->rx_expect))) {
                sllin_report_error(sl, LIN_ERR_RX_TIMEOUT);
                set_bit(SLF_TMOUTEVENT, &sl->flags);
        } else {
@@ -1001,9 +1009,9 @@ static int sllin_kwthread(void *ptr)
                        test_bit(SLF_TXEVENT, &sl->flags) ||
                        test_bit(SLF_TMOUTEVENT, &sl->flags) ||
                        test_bit(SLF_ERROR, &sl->flags) ||
+                       (sl->lin_state == SLSTATE_ID_RECEIVED) ||
                        (((sl->lin_state == SLSTATE_IDLE) ||
-                               (sl->lin_state == SLSTATE_RESPONSE_WAIT) ||
-                               (sl->lin_state == SLSTATE_ID_RECEIVED))
+                               (sl->lin_state == SLSTATE_RESPONSE_WAIT))
                                && test_bit(SLF_MSGEVENT, &sl->flags)));
 
                if (test_and_clear_bit(SLF_RXEVENT, &sl->flags)) {
@@ -1201,8 +1209,7 @@ slstate_response_wait:
                        spin_lock_irqsave(&sl->linfr_lock, flags);
 
                        if ((sce->frame_fl & LIN_CACHE_RESPONSE)
-                                       && (sce->dlc > 0)
-                                       && (test_bit(SLF_MSGEVENT, &sl->flags))) {
+                                       && (sce->dlc > 0)) {
                                int mode;
 
                                netdev_dbg(sl->dev, "Sending LIN response from linfr_cache\n");
@@ -1216,7 +1223,7 @@ slstate_response_wait:
                                tx_bytes = lin_dlc;
 
                                mode = SLLIN_STPMSG_RESPONLY;
-                               if (sl->rx_buff[SLLIN_BUFF_ID] & LIN_CHECKSUM_EXTENDED)
+                               if (sce->frame_fl & LIN_CHECKSUM_EXTENDED)
                                        mode |= SLLIN_STPMSG_CHCKSUM_ENH;
 
                                if (sllin_setup_msg(sl, mode, lin_id & LIN_ID_MASK,
@@ -1234,9 +1241,6 @@ slstate_response_wait:
                                        sllin_send_tx_buff(sl);
                                }
 
-                               clear_bit(SLF_MSGEVENT, &sl->flags);
-                               kfree_skb(sl->tx_req_skb);
-                               netif_wake_queue(sl->dev);
                                hrtimer_start(&sl->rx_timer,
                                        ktime_add(ktime_get(), sl->rx_timer_timeout),
                                        HRTIMER_MODE_ABS);