f2fs: avoid infinite loop in f2fs_alloc_nid

If we have an error in f2fs_build_free_nids, we're able to fall into a loop
to find free nids.

Suggested-by: Chao Yu <chao@kernel.org>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index fa2381c0bc475ecada0fbdeaafc5a86ef06bcda4..d62f53096b55731c8fa87cc9317fe54492ff6c8c 100644 (file)
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -2350,8 +2350,9 @@ retry:
        spin_unlock(&nm_i->nid_list_lock);
 
        /* Let's scan nat pages and its caches to get free nids */
-       f2fs_build_free_nids(sbi, true, false);
-       goto retry;
+       if (!f2fs_build_free_nids(sbi, true, false))
+               goto retry;
+       return false;
 }
 
 /*