staging: ccree: fix ifnullfree.cocci warnings

drivers/staging/ccree/ssi_buffer_mgr.c:530:3-19: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/ccree/ssi_buffer_mgr.c b/drivers/staging/ccree/ssi_buffer_mgr.c
index af50904dc334e5e034cb19448e4bb49f440f530f..038e2ff5e545f4b10e7c6ef34a30926aaffc5496 100644 (file)
--- a/drivers/staging/ccree/ssi_buffer_mgr.c
+++ b/drivers/staging/ccree/ssi_buffer_mgr.c
@@ -1863,8 +1863,7 @@ int ssi_buffer_mgr_fini(struct ssi_drvdata *drvdata)
        struct buff_mgr_handle *buff_mgr_handle = drvdata->buff_mgr_handle;
 
        if (buff_mgr_handle  != NULL) {
-               if (buff_mgr_handle->mlli_buffs_pool != NULL)
-                       dma_pool_destroy(buff_mgr_handle->mlli_buffs_pool);
+               dma_pool_destroy(buff_mgr_handle->mlli_buffs_pool);
                kfree(drvdata->buff_mgr_handle);
                drvdata->buff_mgr_handle = NULL;