]> rtime.felk.cvut.cz Git - zynq/linux.git/commitdiff
usb: phy-zynq: Fix devm_kzalloc() calls
authorSoren Brinkmann <soren.brinkmann@xilinx.com>
Thu, 28 Nov 2013 20:05:10 +0000 (12:05 -0800)
committerMichal Simek <michal.simek@xilinx.com>
Tue, 10 Dec 2013 06:35:04 +0000 (07:35 +0100)
The calls to devm_kzalloc had several issues:
 - missing struct device pointer
 - sizeof argument should be within parentheses
 - sizeof argument should use variable identifier opposed to a type

Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
drivers/usb/phy/phy-zynq-usb.c

index 8b2514fad96fa74777d92c7204f2e624579364c0..c605667b90d38ab92f6f7a4a078d84287f4fa9a3 100644 (file)
@@ -1961,7 +1961,7 @@ static int xusbps_otg_probe(struct platform_device *pdev)
 
        dev_dbg(&pdev->dev, "\notg controller is detected.\n");
 
-       xotg = devm_kzalloc(&pdev->dev, sizeof *xotg, GFP_KERNEL);
+       xotg = devm_kzalloc(&pdev->dev, sizeof(*xotg), GFP_KERNEL);
        if (xotg == NULL)
                return -ENOMEM;
 
@@ -1970,7 +1970,8 @@ static int xusbps_otg_probe(struct platform_device *pdev)
        /* Setup ulpi phy for OTG */
        xotg->ulpi = pdata->ulpi;
 
-       xotg->otg.otg = devm_kzalloc(sizeof(struct usb_otg), GFP_KERNEL);
+       xotg->otg.otg = devm_kzalloc(&pdev->dev, sizeof(*xotg->otg.otg),
+                       GFP_KERNEL);
        if (!xotg->otg.otg)
                return -ENOMEM;