staging: apf: Fixes to error reporting

There were several instances in which apf code could fail silently.
This patch adds descriptive messages to the kernel debug log instead of
just returning an error code.  This is done to aid future debugging.

Signed-off-by: Michael Gill <gill@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>

diff --git a/drivers/staging/apf/xlnk.c b/drivers/staging/apf/xlnk.c
index ebec9af4b41635311726fe294caf6ccff6c9161e..c52061af5e1acba46f1a493931c9d4dca0d6fcaa 100644 (file)
--- a/drivers/staging/apf/xlnk.c
+++ b/drivers/staging/apf/xlnk.c
@@ -142,7 +142,7 @@ static void xlnk_devpacks_init(void)
        unsigned int i;
 
        for (i = 0; i < MAX_XLNK_DMAS; i++)
-               xlnk_devpacks[0] = NULL;
+               xlnk_devpacks[i] = NULL;
 
 }
 
@@ -1232,6 +1232,9 @@ static long xlnk_ioctl(struct file *filp, unsigned int code,
        case XLNK_IOCRECRES: /* recover resource */
                status = xlnk_recover_resource(args);
                break;
+       default:
+               pr_err("xlnk- Unknown ioctl code emitted\n");
+               status = -EINVAL;
        }
 
        return status;
@@ -1265,8 +1268,10 @@ static int xlnk_mmap(struct file *filp, struct vm_area_struct *vma)
                                         vma->vm_end - vma->vm_start,
                                         vma->vm_page_prot);
        }
-       if (status)
+       if (status) {
+               pr_err("xlnk_mmap failed with code %d\n", EAGAIN);
                return -EAGAIN;
+       }
 
        xlnk_vma_open(vma);
        vma->vm_ops = &xlnk_vm_ops;