v4l: xilinx-vpss-csc: Make max width and height mandatory properties

This patch makes xlnx,max-width and xlnx,max-height as mandatory
properties. This breaks backward compatibility and a warning message is
added.

Signed-off-by: Vishal Sagar <vishal.sagar@xilinx.com>
Reviewed-by: Hyun Kwon <hyun.kwon@xilinx.com>

diff --git a/drivers/media/platform/xilinx/xilinx-vpss-csc.c b/drivers/media/platform/xilinx/xilinx-vpss-csc.c
index fd0eedad53eec3d68affb2cd3842eab1cdff5646..0d8da2f7be2711cb3af25a961e9fb9a0047f5cf1 100644 (file)
--- a/drivers/media/platform/xilinx/xilinx-vpss-csc.c
+++ b/drivers/media/platform/xilinx/xilinx-vpss-csc.c
@@ -957,7 +957,8 @@ static int xcsc_parse_of(struct xcsc_dev *xcsc)
 
        rval = of_property_read_u32(node, "xlnx,max-height", &xcsc->max_height);
        if (rval < 0) {
-               xcsc->max_height = XV_CSC_MAX_HEIGHT;
+               dev_err(dev, "xlnx,max-height is missing!");
+               return -EINVAL;
        } else if (xcsc->max_height > XV_CSC_MAX_HEIGHT ||
                   xcsc->max_height < XV_CSC_MIN_HEIGHT) {
                dev_err(dev, "Invalid height in dt");
@@ -966,7 +967,8 @@ static int xcsc_parse_of(struct xcsc_dev *xcsc)
 
        rval = of_property_read_u32(node, "xlnx,max-width", &xcsc->max_width);
        if (rval < 0) {
-               xcsc->max_width = XV_CSC_MAX_WIDTH;
+               dev_err(dev, "xlnx,max-width is missing!");
+               return -EINVAL;
        } else if (xcsc->max_width > XV_CSC_MAX_WIDTH ||
                   xcsc->max_width < XV_CSC_MIN_WIDTH) {
                dev_err(dev, "Invalid width in dt");