]> rtime.felk.cvut.cz Git - zynq/linux.git/commitdiff
dmaengine: vdma: Fix checkpatch.pl warnings
authorKedareswara rao Appana <appana.durga.rao@xilinx.com>
Wed, 6 Apr 2016 05:14:55 +0000 (10:44 +0530)
committerVinod Koul <vinod.koul@intel.com>
Wed, 6 Apr 2016 15:41:17 +0000 (08:41 -0700)
This patch fixes the below checkpatch.pl warnings.

WARNING: void function return statements are not generally useful
+ return;
+}

WARNING: void function return statements are not generally useful
+ return;
+}

WARNING: Missing a blank line after declarations
+ u32 errors = status & XILINX_VDMA_DMASR_ALL_ERR_MASK;
+ vdma_ctrl_write(chan, XILINX_VDMA_REG_DMASR,

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Moritz Fischer <moritz.fischer@ettus.com>
Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/xilinx/xilinx_vdma.c

index b873d98d756b706827803845989512257aa18f90..3c5ce373b99dfd4a4add4359123977da8c3749aa 100644 (file)
@@ -597,8 +597,6 @@ static void xilinx_vdma_halt(struct xilinx_vdma_chan *chan)
                        chan, vdma_ctrl_read(chan, XILINX_VDMA_REG_DMASR));
                chan->err = true;
        }
-
-       return;
 }
 
 /**
@@ -623,8 +621,6 @@ static void xilinx_vdma_start(struct xilinx_vdma_chan *chan)
 
                chan->err = true;
        }
-
-       return;
 }
 
 /**
@@ -874,6 +870,7 @@ static irqreturn_t xilinx_vdma_irq_handler(int irq, void *data)
                 * make sure not to write to other error bits to 1.
                 */
                u32 errors = status & XILINX_VDMA_DMASR_ALL_ERR_MASK;
+
                vdma_ctrl_write(chan, XILINX_VDMA_REG_DMASR,
                                errors & XILINX_VDMA_DMASR_ERR_RECOVER_MASK);