remoteproc: mb: Fix error return path

Do not call rproc_put() when rproc_alloc() failed.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>

diff --git a/drivers/remoteproc/mb_remoteproc.c b/drivers/remoteproc/mb_remoteproc.c
index 2d21c6e14f4dbfed7e271cec29c29b647e7f24f8..8c9cedf2ec7b32dd2d3e88002a4bdfc5d268d483 100644 (file)
--- a/drivers/remoteproc/mb_remoteproc.c
+++ b/drivers/remoteproc/mb_remoteproc.c
@@ -198,21 +198,17 @@ static int mb_remoteproc_probe(struct platform_device *pdev)
                                &mb_rproc_ops, prop, sizeof(struct rproc));
                if (!local->rproc) {
                        dev_err(&pdev->dev, "rproc allocation failed\n");
-                       goto rproc_fault;
+                       return -ENOMEM;
                }
 
                ret = rproc_add(local->rproc);
                if (ret) {
                        dev_err(&pdev->dev, "rproc registration failed\n");
-                       goto rproc_fault;
+                       rproc_put(local->rproc);
+                       return ret;
                }
-
-               return ret;
-       } else
-               ret = -ENODEV;
-
-rproc_fault:
-       rproc_put(local->rproc);
+               return 0;
+       }
 
        return -ENODEV;
 }