]> rtime.felk.cvut.cz Git - zynq/linux.git/commitdiff
net: xilinx: axiethernet: Fix code checker warnings
authorRadhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Thu, 14 Mar 2019 08:46:03 +0000 (14:16 +0530)
committerMichal Simek <michal.simek@xilinx.com>
Fri, 15 Mar 2019 10:23:48 +0000 (11:23 +0100)
Remove map_dma_q_irq() redundant definition and also reduce the scope of
axienet_queue_xmit function. This patch fixes below sparse warnings.

drivers/net/ethernet/xilinx/xilinx_axienet_main.c: At top level:
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1004:5: warning: no previous
prototype for ‘axienet_queue_xmit’ [-Wmissing-prototypes]
int axienet_queue_xmit(struct sk_buff *skb, struct net_device *ndev,
u16 map)
     ^~~~~~~~~~~~~~~~~~
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1471:5: warning: no previous
prototype for ‘map_dma_q_irq’ [-Wmissing-prototypes]
int map_dma_q_irq(int irq, struct axienet_local *lp)

Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
drivers/net/ethernet/xilinx/xilinx_axienet_main.c

index 0462b154538c4cf0b497ac642b87704538e31c49..a235ef89b2579afec1fdbf944c8cadaddfe86d51 100644 (file)
@@ -1001,7 +1001,8 @@ static int axienet_skb_tstsmp(struct sk_buff **__skb, struct axienet_dma_q *q,
 }
 #endif
 
-int axienet_queue_xmit(struct sk_buff *skb, struct net_device *ndev, u16 map)
+static int axienet_queue_xmit(struct sk_buff *skb,
+                             struct net_device *ndev, u16 map)
 {
        u32 ii;
        u32 num_frag;
@@ -1459,27 +1460,6 @@ static irqreturn_t axienet_err_irq(int irq, void *_ndev)
        return IRQ_HANDLED;
 }
 
-/**
- * map_dma_q_irq - Map dma q based on interrupt number.
- * @irq:       irq number
- * @lp:                axienet local structure
- *
- * Return: DMA queue.
- *
- * This returns the DMA number on which interrupt has occurred.
- */
-int map_dma_q_irq(int irq, struct axienet_local *lp)
-{
-       int i;
-
-       for_each_rx_dma_queue(lp, i) {
-               if (irq == lp->dq[i]->tx_irq || irq == lp->dq[i]->rx_irq)
-                       return i;
-       }
-       pr_err("Error mapping DMA irq\n");
-       return -ENODEV;
-}
-
 static int axienet_mii_init(struct net_device *ndev)
 {
        struct axienet_local *lp = netdev_priv(ndev);