]> rtime.felk.cvut.cz Git - zynq/linux.git/commit
tty: xuartps: Don't write IRQ disable register to enable interrupts
authorSoren Brinkmann <soren.brinkmann@xilinx.com>
Wed, 14 May 2014 21:43:01 +0000 (14:43 -0700)
committerMichal Simek <michal.simek@xilinx.com>
Thu, 15 May 2014 06:27:57 +0000 (08:27 +0200)
commitbbb814303983016d8339112847cc6f8af82138a5
tree39f47ea68458f591becb4344c3cee0d9d26d69ef
parent05d0ead1de75521335596448d1703edd60190b36
tty: xuartps: Don't write IRQ disable register to enable interrupts

A comment states, that, according to the data sheet, to enable
interrupts the disable register should be written, but the enable
register could be left untouched. And it suspsects a HW bug requiring
to write both.
Reviewing the data sheet, these statements seem wrong. Just as one would
expect. Writing to the enable/disable register enables/disables
interrupts.
Hence the misleading comment and needless write to the disable register
are removed from the enable sequence.

Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
Tested-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit b494a5fae452fc43519872565892fa873f6ea4fb)
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
drivers/tty/serial/xilinx_uartps.c