]> rtime.felk.cvut.cz Git - zynq/linux.git/commit
tty: xuartps: Don't write IRQ disable register to enable interrupts
authorSoren Brinkmann <soren.brinkmann@xilinx.com>
Sat, 5 Apr 2014 00:23:42 +0000 (17:23 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 24 Apr 2014 23:21:51 +0000 (16:21 -0700)
commitb494a5fae452fc43519872565892fa873f6ea4fb
treeee0666b2b415be4d22ae69532a6ddd363a01356c
parent35dc5a538fb54bc30bdedf4c825da5c970b5ff90
tty: xuartps: Don't write IRQ disable register to enable interrupts

A comment states, that, according to the data sheet, to enable
interrupts the disable register should be written, but the enable
register could be left untouched. And it suspsects a HW bug requiring
to write both.
Reviewing the data sheet, these statements seem wrong. Just as one would
expect. Writing to the enable/disable register enables/disables
interrupts.
Hence the misleading comment and needless write to the disable register
are removed from the enable sequence.

Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
Tested-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/xilinx_uartps.c