]> rtime.felk.cvut.cz Git - zynq/linux.git/blob - scripts/coccinelle/free/put_device.cocci
coccinelle: semantic code search for missing put_device()
[zynq/linux.git] / scripts / coccinelle / free / put_device.cocci
1 // SPDX-License-Identifier: GPL-2.0
2 /// Find missing put_device for every of_find_device_by_node.
3 ///
4 // Confidence: Moderate
5 // Copyright: (C) 2018-2019 Wen Yang, ZTE.
6 // Comments:
7 // Options: --no-includes --include-headers
8
9 virtual report
10 virtual org
11
12 @search exists@
13 local idexpression id;
14 expression x,e,e1;
15 position p1,p2;
16 type T,T1,T2,T3;
17 @@
18
19 id = of_find_device_by_node@p1(x)
20 ... when != e = id
21 if (id == NULL || ...) { ... return ...; }
22 ... when != put_device(&id->dev)
23     when != platform_device_put(id)
24     when != of_dev_put(id)
25     when != if (id) { ... put_device(&id->dev) ... }
26     when != e1 = (T)id
27     when != e1 = &id->dev
28     when != e1 = get_device(&id->dev)
29     when != e1 = (T1)platform_get_drvdata(id)
30 (
31   return
32 (    id
33 |    (T2)dev_get_drvdata(&id->dev)
34 |    (T3)platform_get_drvdata(id)
35 );
36 | return@p2 ...;
37 )
38
39 @script:python depends on report@
40 p1 << search.p1;
41 p2 << search.p2;
42 @@
43
44 coccilib.report.print_report(p2[0], "ERROR: missing put_device; "
45                               + "call of_find_device_by_node on line "
46                               + p1[0].line
47                               + ", but without a corresponding object release "
48                               + "within this function.")
49
50 @script:python depends on org@
51 p1 << search.p1;
52 p2 << search.p2;
53 @@
54
55 cocci.print_main("of_find_device_by_node", p1)
56 cocci.print_secs("needed put_device", p2)