]> rtime.felk.cvut.cz Git - vajnamar/linux-xlnx.git/commitdiff
v4l: xilinx: csi2rxss: Handle failing to create custom control
authorVishal Sagar <vishal.sagar@xilinx.com>
Thu, 10 Aug 2017 07:23:52 +0000 (12:53 +0530)
committerMichal Simek <michal.simek@xilinx.com>
Tue, 15 Aug 2017 10:37:18 +0000 (12:37 +0200)
Correctly handle the error generated while creating new custom control.

Signed-off-by: Vishal Sagar <vsagar@xilinx.com>
Reviewed-by: Hyun Kwon <hyun.kwon@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
drivers/media/platform/xilinx/xilinx-csi2rxss.c

index 531756872ddaa39581ffc4c040439ecb5cb21cb9..33191a5ea6510181b33a8a9fc0c948b5d5fb3be8 100644 (file)
@@ -1675,6 +1675,11 @@ static int xcsi2rxss_probe(struct platform_device *pdev)
                                i, xcsi2rxss_ctrls[i].id);
                ctrl = v4l2_ctrl_new_custom(&xcsi2rxss->ctrl_handler,
                                                &xcsi2rxss_ctrls[i], NULL);
+               if (!ctrl) {
+                       dev_err(xcsi2rxss->core.dev, "Failed for %s ctrl\n",
+                               xcsi2rxss_ctrls[i].name);
+                       goto error;
+               }
        }
 
        dev_dbg(xcsi2rxss->core.dev, "# v4l2 ctrls registered = %d\n", i - 1);