]> rtime.felk.cvut.cz Git - sojka/nv-tegra/linux-3.10.git/commitdiff
platform: nvadsp: fix lock usage
authorShridhar Rasal <srasal@nvidia.com>
Thu, 9 Oct 2014 02:51:20 +0000 (08:21 +0530)
committerSachin Nikam <snikam@nvidia.com>
Mon, 13 Oct 2014 09:28:53 +0000 (02:28 -0700)
Fix spin lock use in app_start context.
This is reported by sparse as warning:
app.c +769: warning: context imbalance in 'nvadsp_app_start'
-different lock contexts for basic block

Bug 200032218

Change-Id: I27ed927325e4cd90ab28cf52111eddc81ccffd11
Signed-off-by: Shridhar Rasal <srasal@nvidia.com>
Reviewed-on: http://git-master/r/554834
Reviewed-by: Amit Sharma (SW-TEGRA) <amisharma@nvidia.com>
Reviewed-by: Sachin Nikam <snikam@nvidia.com>
drivers/platform/tegra/nvadsp/app.c

index 6be67410b9f72bd9239eec2ae58949925d562187..09c6731c0f66534e834f35158d3c00f61bd6fa0c 100644 (file)
@@ -962,6 +962,8 @@ int nvadsp_app_start(nvadsp_app_info_t *app)
                 */
                if (app->complete_status_notifier)
                        schedule_work(&app->complete_work);
+       } else {
+               spin_unlock_irqrestore(&state_lock, flags);
        }
 end:
        print_start_stats(ser->file, &stats, dev);