]> rtime.felk.cvut.cz Git - sojka/nv-tegra/linux-3.10.git/commitdiff
usb: gadget: tegra: fix Coverity issue
authorDeepak Nibade <dnibade@nvidia.com>
Tue, 3 Dec 2013 14:04:27 +0000 (19:34 +0530)
committerNitin Kumbhar <nkumbhar@nvidia.com>
Wed, 4 Dec 2013 10:21:34 +0000 (02:21 -0800)
fix Coverity issue of dereference after NULL check
Coverity id : 25261

Bug 1416640

Change-Id: I071dd86d87118c01b295efd687950017c461456f
Signed-off-by: Deepak Nibade <dnibade@nvidia.com>
Reviewed-on: http://git-master/r/337817
Reviewed-by: Automatic_Commit_Validation_User
Reviewed-by: Rohith Seelaboyina <rseelaboyina@nvidia.com>
Reviewed-by: Sumit Singh <sumsingh@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Sri Krishna Chowdary <schowdary@nvidia.com>
Reviewed-by: Rakesh Babu Bodla <rbodla@nvidia.com>
Reviewed-by: Nitin Kumbhar <nkumbhar@nvidia.com>
drivers/usb/gadget/tegra_udc.c

index e373babda13adf1b14cb2e2b1fb6d79c2795de1c..8204428d58a3f16a21b2c43fecb2afacb35cd3ed 100644 (file)
@@ -2847,8 +2847,11 @@ static int __init tegra_udc_probe(struct platform_device *pdev)
                else
                        udc->dcp_current_limit =
                                USB_CHARGING_DCP_CURRENT_LIMIT_UA;
-       } else
+       } else {
                dev_err(&pdev->dev, "failed to get platform_data\n");
+               err = -ENODATA;
+               goto err_irq;
+       }
 
        udc->phy = tegra_usb_phy_open(pdev);
        if (IS_ERR(udc->phy)) {