]> rtime.felk.cvut.cz Git - sojka/nv-tegra/linux-3.10.git/commitdiff
video: tegra: host: gk20a: fix resource leaks
authorDeepak Nibade <dnibade@nvidia.com>
Tue, 17 Dec 2013 11:35:40 +0000 (17:05 +0530)
committerSachin Nikam <snikam@nvidia.com>
Wed, 18 Dec 2013 05:38:25 +0000 (21:38 -0800)
fix Coverity issues of resource leaks
Coverity id : 25341
Coverity id : 25342

Bug 1416640

Change-Id: I31286753c8c36e98203180141ae7b2fe456aa30d
Signed-off-by: Deepak Nibade <dnibade@nvidia.com>
Reviewed-on: http://git-master/r/346465
Reviewed-by: Sachin Nikam <snikam@nvidia.com>
Tested-by: Sachin Nikam <snikam@nvidia.com>
drivers/video/tegra/host/gk20a/gr_gk20a.c

index 884168da22ab82a53ee09c8ead1d1f6243b8cb2c..4259a4c7a356f932c66e2da10578c5e3408566a8 100644 (file)
@@ -3916,12 +3916,18 @@ static int gr_gk20a_zcull_init_hw(struct gk20a *g, struct gr_gk20a *gr)
 
        zcull_map_tiles = kzalloc(proj_scal_max_gpcs_v() *
                        proj_scal_max_tpc_per_gpc_v() * sizeof(u32), GFP_KERNEL);
+       if (!zcull_map_tiles) {
+               nvhost_err(dev_from_gk20a(g),
+                       "failed to allocate zcull temp buffers");
+               return -ENOMEM;
+       }
        zcull_bank_counters = kzalloc(proj_scal_max_gpcs_v() *
                        proj_scal_max_tpc_per_gpc_v() * sizeof(u32), GFP_KERNEL);
 
-       if (!zcull_map_tiles || !zcull_bank_counters) {
+       if (!zcull_bank_counters) {
                nvhost_err(dev_from_gk20a(g),
                        "failed to allocate zcull temp buffers");
+               kfree(zcull_map_tiles);
                return -ENOMEM;
        }