HID: hidraw: Fix memory leak in list->buffer

Deallocate memory allocated to list->buffer[x].value on
release

Bug 1677312

Change-Id: Iaf320327e917b3e78b07230819d51053e43e2c25
Signed-off-by: Ankita Garg <ankitag@nvidia.com>
Reviewed-on: http://git-master/r/791189
GVS: Gerrit_Virtual_Submit
Reviewed-by: Raymond Poudrier <rapoudrier@nvidia.com>
Reviewed-by: Eric Chuang <echuang@nvidia.com>

diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c
index 5fe2fe3eac785aa9cabfb837ac1ce03a0a7bc09c..36a6bef03de0cd5996e747d294a4dbb8398eebac 100644 (file)
--- a/drivers/hid/hidraw.c
+++ b/drivers/hid/hidraw.c
@@ -338,9 +338,14 @@ static int hidraw_release(struct inode * inode, struct file * file)
 {
        unsigned int minor = iminor(inode);
        struct hidraw_list *list = file->private_data;
+       int i;
 
        mutex_lock(&minors_lock);
 
+       for (i = 0; i < HIDRAW_BUFFER_SIZE; i++) {
+               kfree(list->buffer[i].value);
+       }
+
        list_del(&list->node);
        kfree(list);