]> rtime.felk.cvut.cz Git - orte.git/commitdiff
JORTE: fix incompatible pointer type compiler warnings
authorMartin Vajnar <martin.vajnar@gmail.com>
Fri, 13 Sep 2013 10:08:23 +0000 (12:08 +0200)
committerPavel Pisa <pisa@cmp.felk.cvut.cz>
Mon, 23 Sep 2013 09:06:28 +0000 (11:06 +0200)
Android's AttachCurrentThread() implementation differs from Oracle's.
In Android the prototype is:
  jint (*AttachCurrentThread)(JavaVM*, JNIEnv**, void*);
In Oracle's Java:
  jint (JNICALL *AttachCurrentThread)(JavaVM *vm, void **penv, void *args);

Android expects JNIEnv** pointer, whereas Java expects void** pointer
to per thread environment structure.

orte/libjorte/JORTEDomainEvents.c
orte/libjorte/JORTESubscriptionCreate.c

index 1a75046ac1967c0e973cff4f72c61f39e62f85ce..1241d7b4b2566af2a0e00976808628307fda1661 100644 (file)
@@ -37,7 +37,13 @@ onRegFail(void *param)
     }
     jvm = domain_events_cont->jvm;
     // get env
-    (*jvm)->AttachCurrentThread(jvm, (void **)&env, NULL);
+    (*jvm)->AttachCurrentThread(jvm,
+                                #ifdef __ANDROID__
+                                  &env,
+                                #else
+                                  (void **)&env,
+                                #endif
+                                NULL);
     if(env == 0)
     {
      #ifdef TEST_STAGE
@@ -119,7 +125,13 @@ onMgrNew(const struct ORTEAppInfo *appInfo, void *param)
     }
     jvm = domain_events_cont->jvm;
     // get env
-    (*jvm)->AttachCurrentThread(jvm, (void **)&env, NULL);
+    (*jvm)->AttachCurrentThread(jvm,
+                                #ifdef __ANDROID__
+                                  &env,
+                                #else
+                                  (void **)&env,
+                                #endif
+                                NULL);
     if(env == 0)
     {
      #ifdef TEST_STAGE
@@ -211,7 +223,13 @@ onMgrDelete(const struct ORTEAppInfo *appInfo, void *param)
     }
     jvm = domain_events_cont->jvm;
     // get env
-    (*jvm)->AttachCurrentThread(jvm, (void **)&env, NULL);
+    (*jvm)->AttachCurrentThread(jvm,
+                                #ifdef __ANDROID__
+                                  &env,
+                                #else
+                                  (void **)&env,
+                                #endif
+                                NULL);
     if(env == 0)
     {
      #ifdef TEST_STAGE
@@ -304,7 +322,13 @@ onAppRemoteNew(const struct ORTEAppInfo *appInfo, void *param)
     }
     jvm = domain_events_cont->jvm;
     // get env
-    (*jvm)->AttachCurrentThread(jvm, (void **)&env, NULL);
+    (*jvm)->AttachCurrentThread(jvm,
+                                #ifdef __ANDROID__
+                                  &env,
+                                #else
+                                  (void **)&env,
+                                #endif
+                                NULL);
     if(env == 0)
     {
      #ifdef TEST_STAGE
@@ -397,7 +421,13 @@ onAppDelete(const struct ORTEAppInfo *appInfo, void *param)
     }
     jvm = domain_events_cont->jvm;
     // get env
-    (*jvm)->AttachCurrentThread(jvm, (void **)&env, NULL);
+    (*jvm)->AttachCurrentThread(jvm,
+                                #ifdef __ANDROID__
+                                  &env,
+                                #else
+                                  (void **)&env,
+                                #endif
+                                NULL);
     if(env == 0)
     {
      #ifdef TEST_STAGE
@@ -492,7 +522,13 @@ onPubRemoteNew(const struct ORTEAppInfo *appInfo,
     }
     jvm = domain_events_cont->jvm;
     // get env
-    (*jvm)->AttachCurrentThread(jvm, (void **)&env, NULL);
+    (*jvm)->AttachCurrentThread(jvm,
+                                #ifdef __ANDROID__
+                                  &env,
+                                #else
+                                  (void **)&env,
+                                #endif
+                                NULL);
     if(env == 0)
     {
      #ifdef TEST_STAGE
@@ -597,7 +633,13 @@ onPubRemoteChanged(const struct ORTEAppInfo *appInfo,
     }
     jvm = domain_events_cont->jvm;
     // get env
-    (*jvm)->AttachCurrentThread(jvm, (void **)&env, NULL);
+    (*jvm)->AttachCurrentThread(jvm,
+                                #ifdef __ANDROID__
+                                  &env,
+                                #else
+                                  (void **)&env,
+                                #endif
+                                NULL);
     if(env == 0)
     {
      #ifdef TEST_STAGE
@@ -704,7 +746,13 @@ onPubDelete(const struct ORTEAppInfo *appInfo,
     }
     jvm = domain_events_cont->jvm;
     // get env
-    (*jvm)->AttachCurrentThread(jvm, (void **)&env, NULL);
+    (*jvm)->AttachCurrentThread(jvm,
+                                #ifdef __ANDROID__
+                                  &env,
+                                #else
+                                  (void **)&env,
+                                #endif
+                                NULL);
     if(env == 0)
     {
      #ifdef TEST_STAGE
@@ -809,7 +857,13 @@ onSubRemoteNew(const struct ORTEAppInfo *appInfo,
     }
     jvm = domain_events_cont->jvm;
     // get env
-    (*jvm)->AttachCurrentThread(jvm, (void **)&env, NULL);
+    (*jvm)->AttachCurrentThread(jvm,
+                                #ifdef __ANDROID__
+                                  &env,
+                                #else
+                                  (void **)&env,
+                                #endif
+                                NULL);
     if(env == 0)
     {
      #ifdef TEST_STAGE
@@ -914,7 +968,13 @@ onSubRemoteChanged(const struct ORTEAppInfo *appInfo,
     }
     jvm = domain_events_cont->jvm;
     // get env
-    (*jvm)->AttachCurrentThread(jvm, (void **)&env, NULL);
+    (*jvm)->AttachCurrentThread(jvm,
+                                #ifdef __ANDROID__
+                                  &env,
+                                #else
+                                  (void **)&env,
+                                #endif
+                                NULL);
     if(env == 0)
     {
      #ifdef TEST_STAGE
@@ -1019,7 +1079,13 @@ onSubDelete(const struct ORTEAppInfo *appInfo,
     }
     jvm = domain_events_cont->jvm;
     // get env
-    (*jvm)->AttachCurrentThread(jvm, (void **)&env, NULL);
+    (*jvm)->AttachCurrentThread(jvm,
+                                #ifdef __ANDROID__
+                                  &env,
+                                #else
+                                  (void **)&env,
+                                #endif
+                                NULL);
     if(env == 0)
     {
      #ifdef TEST_STAGE
@@ -1086,4 +1152,4 @@ onSubDelete(const struct ORTEAppInfo *appInfo,
   }
 
   return ORTE_TRUE;
-}
\ No newline at end of file
+}
index 599f9c8621dc81de34fd05a0c7ce2f6296b731d3..b02edea7227c2c06254959bdf8dc73a2d13ce25f 100644 (file)
@@ -76,7 +76,13 @@ recvCallBack(const ORTERecvInfo *info,void *vinstance, void *recvCallBackParam)
     }
     jvm = callback_cont->jvm;
     // get env
-    (*jvm)->AttachCurrentThread(jvm, (void **)&env, NULL);
+    (*jvm)->AttachCurrentThread(jvm,
+                                #ifdef __ANDROID__
+                                  &env,
+                                #else
+                                  (void **)&env,
+                                #endif
+                                NULL);
     if(env == 0)
     {
       #ifdef TEST_STAGE