]> rtime.felk.cvut.cz Git - linux-imx.git/commitdiff
usb: dwc3: core: don't kfree() devm_kzalloc()'ed memory
authorFelipe Balbi <balbi@ti.com>
Thu, 8 Nov 2012 13:26:41 +0000 (15:26 +0200)
committerFelipe Balbi <balbi@ti.com>
Thu, 8 Nov 2012 13:26:41 +0000 (15:26 +0200)
commit 380f0d2 (usb: dwc3: core: switch event
buffer allocation to devm_kzalloc()) was incomplete
leaving a trailing kfree(evt) in an error exit
path.

Fix this problem by removing the trailing kfree(evt).

Cc: Julia Lawall <julia.lawall@lip6.fr>
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/dwc3/core.c

index d8d327a5e53b1b0c2be21410df165745da5f25ce..2bd007d1646164ed3b5d7279eefd1678037615b8 100644 (file)
@@ -153,10 +153,8 @@ dwc3_alloc_one_event_buffer(struct dwc3 *dwc, unsigned length)
        evt->length     = length;
        evt->buf        = dma_alloc_coherent(dwc->dev, length,
                        &evt->dma, GFP_KERNEL);
-       if (!evt->buf) {
-               kfree(evt);
+       if (!evt->buf)
                return ERR_PTR(-ENOMEM);
-       }
 
        return evt;
 }