]> rtime.felk.cvut.cz Git - linux-imx.git/commitdiff
Revert "backlight: fix memory leak on obscure error path"
authorJiri Kosina <jkosina@suse.cz>
Mon, 30 Jul 2012 08:40:28 +0000 (10:40 +0200)
committerJiri Kosina <jkosina@suse.cz>
Mon, 30 Jul 2012 08:40:28 +0000 (10:40 +0200)
This reverts commit 9ea3c498962bc63748e92c31c874169ab0726324.

'data' is being allocated by devm_kzalloc(), is it's actually
wrong to free() it in the error path, as it will be destroyed
properly later.

Reported-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/video/backlight/88pm860x_bl.c

index f75da8758adcf79612d6a8b5b566a00624a0e42f..f49181c7311390c471b0abc6caa6d8ca6ae4de91 100644 (file)
@@ -228,7 +228,6 @@ static int pm860x_backlight_probe(struct platform_device *pdev)
        data->port = pdata->flags;
        if (data->port < 0) {
                dev_err(&pdev->dev, "wrong platform data is assigned");
-               kfree(data);
                return -EINVAL;
        }