]> rtime.felk.cvut.cz Git - linux-imx.git/commitdiff
staging: omapdrm/omap_gem_dmabuf.c: fix memory leakage
authorCong Ding <dinggnu@gmail.com>
Tue, 15 Jan 2013 19:46:50 +0000 (20:46 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Jan 2013 21:19:55 +0000 (13:19 -0800)
There is a memory leakage in variable sg if it goes to error.

Signed-off-by: Cong Ding <dinggnu@gmail.com>
Signed-off-by: Rob Clark <rob@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/omapdrm/omap_gem_dmabuf.c

index eabb8b57f6c32d09dd5e64638507c51b765cfcc5..27780b8bf15523da60df75abbbca5a130db78d18 100644 (file)
@@ -53,10 +53,10 @@ static struct sg_table *omap_gem_map_dma_buf(
        /* this should be after _get_paddr() to ensure we have pages attached */
        omap_gem_dma_sync(obj, dir);
 
-out:
-       if (ret)
-               return ERR_PTR(ret);
        return sg;
+out:
+       kfree(sg);
+       return ERR_PTR(ret);
 }
 
 static void omap_gem_unmap_dma_buf(struct dma_buf_attachment *attachment,