]> rtime.felk.cvut.cz Git - linux-imx.git/commitdiff
ARM: OMAP2+: gpmc: Remove unneeded of_node_put()
authorEzequiel Garcia <ezequiel.garcia@free-electrons.com>
Fri, 25 Jan 2013 12:19:47 +0000 (09:19 -0300)
committerTony Lindgren <tony@atomide.com>
Fri, 1 Feb 2013 21:55:45 +0000 (13:55 -0800)
for_each_node_by_name() automatically calls of_node_put() on each
node passed; so don't do it explicitly unless there's an error.

Reported-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Acked-by: Jon Hunter <jon-hunter@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
arch/arm/mach-omap2/gpmc.c

index 01ce462e265dd19e7f0f0adfa92f5f0b71e1fc31..c6255f788ab2993a08950b57f75ccf61bdc2aecb 100644 (file)
@@ -1271,9 +1271,10 @@ static int gpmc_probe_dt(struct platform_device *pdev)
 
        for_each_node_by_name(child, "nand") {
                ret = gpmc_probe_nand_child(pdev, child);
-               of_node_put(child);
-               if (ret < 0)
+               if (ret < 0) {
+                       of_node_put(child);
                        return ret;
+               }
        }
 
        return 0;