]> rtime.felk.cvut.cz Git - linux-imx.git/commitdiff
pinctrl: coh901: Return proper error if irq_domain_add_linear() fails
authorAxel Lin <axel.lin@ingics.com>
Tue, 13 Nov 2012 16:16:14 +0000 (00:16 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Thu, 15 Nov 2012 11:17:04 +0000 (12:17 +0100)
Return -ENOMEM instead of 0 if irq_domain_add_linear fails.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-coh901.c

index 5c7daf9169e8ba44008afb681c6a108b72aa7d39..1144dcdf2da03ade1c8cc8793227d06641f3ba61 100644 (file)
@@ -752,8 +752,10 @@ static int __init u300_gpio_probe(struct platform_device *pdev)
                                                     U300_GPIO_PINS_PER_PORT,
                                                     &irq_domain_simple_ops,
                                                     port);
-               if (!port->domain)
+               if (!port->domain) {
+                       err = -ENOMEM;
                        goto err_no_domain;
+               }
 
                irq_set_chained_handler(port->irq, u300_gpio_irq_handler);
                irq_set_handler_data(port->irq, port);
@@ -801,7 +803,7 @@ err_no_domain:
 err_no_port:
        u300_gpio_free_ports(gpio);
        clk_disable_unprepare(gpio->clk);
-       dev_info(&pdev->dev, "module ERROR:%d\n", err);
+       dev_err(&pdev->dev, "module ERROR:%d\n", err);
        return err;
 }