]> rtime.felk.cvut.cz Git - linux-imx.git/commitdiff
wl3501_cs: use is_broadcast_ether_addr() instead of memcmp()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Sun, 26 Aug 2012 01:24:21 +0000 (09:24 +0800)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 7 Sep 2012 19:03:40 +0000 (15:03 -0400)
Using is_broadcast_ether_addr() instead of directly use
memcmp() to determine if the ethernet address is broadcast
address.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/wl3501_cs.c

index 00f6e69c1dcd6f47e3f1e916cf26f923b9f0e1ea..730186d0449b281b08242a1116c2f85115248f04 100644 (file)
@@ -1520,13 +1520,12 @@ static int wl3501_set_wap(struct net_device *dev, struct iw_request_info *info,
                          union iwreq_data *wrqu, char *extra)
 {
        struct wl3501_card *this = netdev_priv(dev);
-       static const u8 bcast[ETH_ALEN] = { 255, 255, 255, 255, 255, 255 };
        int rc = -EINVAL;
 
        /* FIXME: we support other ARPHRDs...*/
        if (wrqu->ap_addr.sa_family != ARPHRD_ETHER)
                goto out;
-       if (!memcmp(bcast, wrqu->ap_addr.sa_data, ETH_ALEN)) {
+       if (is_broadcast_ether_addr(wrqu->ap_addr.sa_data)) {
                /* FIXME: rescan? */
        } else
                memcpy(this->bssid, wrqu->ap_addr.sa_data, ETH_ALEN);