1 /******************************************************************************
3 * Module Name: nsrepair2 - Repair for objects returned by specific
6 *****************************************************************************/
8 /******************************************************************************
12 * Some or all of this work - Copyright (c) 1999 - 2012, Intel Corp.
13 * All rights reserved.
17 * 2.1. This is your license from Intel Corp. under its intellectual property
18 * rights. You may have additional license terms from the party that provided
19 * you this software, covering your right to use that party's intellectual
22 * 2.2. Intel grants, free of charge, to any person ("Licensee") obtaining a
23 * copy of the source code appearing in this file ("Covered Code") an
24 * irrevocable, perpetual, worldwide license under Intel's copyrights in the
25 * base code distributed originally by Intel ("Original Intel Code") to copy,
26 * make derivatives, distribute, use and display any portion of the Covered
27 * Code in any form, with the right to sublicense such rights; and
29 * 2.3. Intel grants Licensee a non-exclusive and non-transferable patent
30 * license (with the right to sublicense), under only those claims of Intel
31 * patents that are infringed by the Original Intel Code, to make, use, sell,
32 * offer to sell, and import the Covered Code and derivative works thereof
33 * solely to the minimum extent necessary to exercise the above copyright
34 * license, and in no event shall the patent license extend to any additions
35 * to or modifications of the Original Intel Code. No other license or right
36 * is granted directly or by implication, estoppel or otherwise;
38 * The above copyright and patent license is granted only if the following
43 * 3.1. Redistribution of Source with Rights to Further Distribute Source.
44 * Redistribution of source code of any substantial portion of the Covered
45 * Code or modification with rights to further distribute source must include
46 * the above Copyright Notice, the above License, this list of Conditions,
47 * and the following Disclaimer and Export Compliance provision. In addition,
48 * Licensee must cause all Covered Code to which Licensee contributes to
49 * contain a file documenting the changes Licensee made to create that Covered
50 * Code and the date of any change. Licensee must include in that file the
51 * documentation of any changes made by any predecessor Licensee. Licensee
52 * must include a prominent statement that the modification is derived,
53 * directly or indirectly, from Original Intel Code.
55 * 3.2. Redistribution of Source with no Rights to Further Distribute Source.
56 * Redistribution of source code of any substantial portion of the Covered
57 * Code or modification without rights to further distribute source must
58 * include the following Disclaimer and Export Compliance provision in the
59 * documentation and/or other materials provided with distribution. In
60 * addition, Licensee may not authorize further sublicense of source of any
61 * portion of the Covered Code, and must include terms to the effect that the
62 * license from Licensee to its licensee is limited to the intellectual
63 * property embodied in the software Licensee provides to its licensee, and
64 * not to intellectual property embodied in modifications its licensee may
67 * 3.3. Redistribution of Executable. Redistribution in executable form of any
68 * substantial portion of the Covered Code or modification must reproduce the
69 * above Copyright Notice, and the following Disclaimer and Export Compliance
70 * provision in the documentation and/or other materials provided with the
73 * 3.4. Intel retains all right, title, and interest in and to the Original
76 * 3.5. Neither the name Intel nor any other trademark owned or controlled by
77 * Intel shall be used in advertising or otherwise to promote the sale, use or
78 * other dealings in products derived from or relating to the Covered Code
79 * without prior written authorization from Intel.
81 * 4. Disclaimer and Export Compliance
83 * 4.1. INTEL MAKES NO WARRANTY OF ANY KIND REGARDING ANY SOFTWARE PROVIDED
84 * HERE. ANY SOFTWARE ORIGINATING FROM INTEL OR DERIVED FROM INTEL SOFTWARE
85 * IS PROVIDED "AS IS," AND INTEL WILL NOT PROVIDE ANY SUPPORT, ASSISTANCE,
86 * INSTALLATION, TRAINING OR OTHER SERVICES. INTEL WILL NOT PROVIDE ANY
87 * UPDATES, ENHANCEMENTS OR EXTENSIONS. INTEL SPECIFICALLY DISCLAIMS ANY
88 * IMPLIED WARRANTIES OF MERCHANTABILITY, NONINFRINGEMENT AND FITNESS FOR A
91 * 4.2. IN NO EVENT SHALL INTEL HAVE ANY LIABILITY TO LICENSEE, ITS LICENSEES
92 * OR ANY OTHER THIRD PARTY, FOR ANY LOST PROFITS, LOST DATA, LOSS OF USE OR
93 * COSTS OF PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES, OR FOR ANY INDIRECT,
94 * SPECIAL OR CONSEQUENTIAL DAMAGES ARISING OUT OF THIS AGREEMENT, UNDER ANY
95 * CAUSE OF ACTION OR THEORY OF LIABILITY, AND IRRESPECTIVE OF WHETHER INTEL
96 * HAS ADVANCE NOTICE OF THE POSSIBILITY OF SUCH DAMAGES. THESE LIMITATIONS
97 * SHALL APPLY NOTWITHSTANDING THE FAILURE OF THE ESSENTIAL PURPOSE OF ANY
100 * 4.3. Licensee shall not export, either directly or indirectly, any of this
101 * software or system incorporating such software without first obtaining any
102 * required license or other approval from the U. S. Department of Commerce or
103 * any other agency or department of the United States Government. In the
104 * event Licensee exports any such software from the United States or
105 * re-exports any such software from a foreign destination, Licensee shall
106 * ensure that the distribution and export/re-export of the software is in
107 * compliance with all laws, regulations, orders, or other restrictions of the
108 * U.S. Export Administration Regulations. Licensee agrees that neither it nor
109 * any of its subsidiaries will export/re-export any technical data, process,
110 * software, or service, directly or indirectly, to any country for which the
111 * United States government or any agency thereof requires an export license,
112 * other governmental approval, or letter of assurance, without first obtaining
113 * such license, approval or letter.
115 *****************************************************************************/
117 #define __NSREPAIR2_C__
120 #include "accommon.h"
121 #include "acnamesp.h"
123 #define _COMPONENT ACPI_NAMESPACE
124 ACPI_MODULE_NAME ("nsrepair2")
128 * Information structure and handler for ACPI predefined names that can
129 * be repaired on a per-name basis.
132 ACPI_STATUS (*ACPI_REPAIR_FUNCTION) (
133 ACPI_PREDEFINED_DATA *Data,
134 ACPI_OPERAND_OBJECT **ReturnObjectPtr);
136 typedef struct acpi_repair_info
138 char Name[ACPI_NAME_SIZE];
139 ACPI_REPAIR_FUNCTION RepairFunction;
144 /* Local prototypes */
146 static const ACPI_REPAIR_INFO *
147 AcpiNsMatchRepairableName (
148 ACPI_NAMESPACE_NODE *Node);
152 ACPI_PREDEFINED_DATA *Data,
153 ACPI_OPERAND_OBJECT **ReturnObjectPtr);
157 ACPI_PREDEFINED_DATA *Data,
158 ACPI_OPERAND_OBJECT **ReturnObjectPtr);
162 ACPI_PREDEFINED_DATA *Data,
163 ACPI_OPERAND_OBJECT **ReturnObjectPtr);
167 ACPI_PREDEFINED_DATA *Data,
168 ACPI_OPERAND_OBJECT **ReturnObjectPtr);
172 ACPI_PREDEFINED_DATA *Data,
173 ACPI_OPERAND_OBJECT **ReturnObjectPtr);
177 ACPI_PREDEFINED_DATA *Data,
178 ACPI_OPERAND_OBJECT **ReturnObjectPtr);
181 AcpiNsCheckSortedList (
182 ACPI_PREDEFINED_DATA *Data,
183 ACPI_OPERAND_OBJECT *ReturnObject,
184 UINT32 ExpectedCount,
191 ACPI_OPERAND_OBJECT **Elements,
194 UINT8 SortDirection);
196 /* Values for SortDirection above */
198 #define ACPI_SORT_ASCENDING 0
199 #define ACPI_SORT_DESCENDING 1
203 * This table contains the names of the predefined methods for which we can
204 * perform more complex repairs.
208 * _ALR: Sort the list ascending by AmbientIlluminance
209 * _CID: Strings: uppercase all, remove any leading asterisk
210 * _FDE: Convert Buffer of BYTEs to a Buffer of DWORDs
211 * _GTM: Convert Buffer of BYTEs to a Buffer of DWORDs
212 * _HID: Strings: uppercase all, remove any leading asterisk
213 * _PSS: Sort the list descending by Power
214 * _TSS: Sort the list descending by Power
216 * Names that must be packages, but cannot be sorted:
218 * _BCL: Values are tied to the Package index where they appear, and cannot
219 * be moved or sorted. These index values are used for _BQC and _BCM.
220 * However, we can fix the case where a buffer is returned, by converting
221 * it to a Package of integers.
223 static const ACPI_REPAIR_INFO AcpiNsRepairableNames[] =
225 {"_ALR", AcpiNsRepair_ALR},
226 {"_CID", AcpiNsRepair_CID},
227 {"_FDE", AcpiNsRepair_FDE},
228 {"_GTM", AcpiNsRepair_FDE}, /* _GTM has same repair as _FDE */
229 {"_HID", AcpiNsRepair_HID},
230 {"_PSS", AcpiNsRepair_PSS},
231 {"_TSS", AcpiNsRepair_TSS},
232 {{0,0,0,0}, NULL} /* Table terminator */
236 #define ACPI_FDE_FIELD_COUNT 5
237 #define ACPI_FDE_BYTE_BUFFER_SIZE 5
238 #define ACPI_FDE_DWORD_BUFFER_SIZE (ACPI_FDE_FIELD_COUNT * sizeof (UINT32))
241 /******************************************************************************
243 * FUNCTION: AcpiNsComplexRepairs
245 * PARAMETERS: Data - Pointer to validation data structure
246 * Node - Namespace node for the method/object
247 * ValidateStatus - Original status of earlier validation
248 * ReturnObjectPtr - Pointer to the object returned from the
249 * evaluation of a method or object
251 * RETURN: Status. AE_OK if repair was successful. If name is not
252 * matched, ValidateStatus is returned.
254 * DESCRIPTION: Attempt to repair/convert a return object of a type that was
257 *****************************************************************************/
260 AcpiNsComplexRepairs (
261 ACPI_PREDEFINED_DATA *Data,
262 ACPI_NAMESPACE_NODE *Node,
263 ACPI_STATUS ValidateStatus,
264 ACPI_OPERAND_OBJECT **ReturnObjectPtr)
266 const ACPI_REPAIR_INFO *Predefined;
270 /* Check if this name is in the list of repairable names */
272 Predefined = AcpiNsMatchRepairableName (Node);
275 return (ValidateStatus);
278 Status = Predefined->RepairFunction (Data, ReturnObjectPtr);
283 /******************************************************************************
285 * FUNCTION: AcpiNsMatchRepairableName
287 * PARAMETERS: Node - Namespace node for the method/object
289 * RETURN: Pointer to entry in repair table. NULL indicates not found.
291 * DESCRIPTION: Check an object name against the repairable object list.
293 *****************************************************************************/
295 static const ACPI_REPAIR_INFO *
296 AcpiNsMatchRepairableName (
297 ACPI_NAMESPACE_NODE *Node)
299 const ACPI_REPAIR_INFO *ThisName;
302 /* Search info table for a repairable predefined method/object name */
304 ThisName = AcpiNsRepairableNames;
305 while (ThisName->RepairFunction)
307 if (ACPI_COMPARE_NAME (Node->Name.Ascii, ThisName->Name))
314 return (NULL); /* Not found */
318 /******************************************************************************
320 * FUNCTION: AcpiNsRepair_ALR
322 * PARAMETERS: Data - Pointer to validation data structure
323 * ReturnObjectPtr - Pointer to the object returned from the
324 * evaluation of a method or object
326 * RETURN: Status. AE_OK if object is OK or was repaired successfully
328 * DESCRIPTION: Repair for the _ALR object. If necessary, sort the object list
329 * ascending by the ambient illuminance values.
331 *****************************************************************************/
335 ACPI_PREDEFINED_DATA *Data,
336 ACPI_OPERAND_OBJECT **ReturnObjectPtr)
338 ACPI_OPERAND_OBJECT *ReturnObject = *ReturnObjectPtr;
342 Status = AcpiNsCheckSortedList (Data, ReturnObject, 2, 1,
343 ACPI_SORT_ASCENDING, "AmbientIlluminance");
349 /******************************************************************************
351 * FUNCTION: AcpiNsRepair_FDE
353 * PARAMETERS: Data - Pointer to validation data structure
354 * ReturnObjectPtr - Pointer to the object returned from the
355 * evaluation of a method or object
357 * RETURN: Status. AE_OK if object is OK or was repaired successfully
359 * DESCRIPTION: Repair for the _FDE and _GTM objects. The expected return
360 * value is a Buffer of 5 DWORDs. This function repairs a common
361 * problem where the return value is a Buffer of BYTEs, not
364 *****************************************************************************/
368 ACPI_PREDEFINED_DATA *Data,
369 ACPI_OPERAND_OBJECT **ReturnObjectPtr)
371 ACPI_OPERAND_OBJECT *ReturnObject = *ReturnObjectPtr;
372 ACPI_OPERAND_OBJECT *BufferObject;
378 ACPI_FUNCTION_NAME (NsRepair_FDE);
381 switch (ReturnObject->Common.Type)
383 case ACPI_TYPE_BUFFER:
385 /* This is the expected type. Length should be (at least) 5 DWORDs */
387 if (ReturnObject->Buffer.Length >= ACPI_FDE_DWORD_BUFFER_SIZE)
392 /* We can only repair if we have exactly 5 BYTEs */
394 if (ReturnObject->Buffer.Length != ACPI_FDE_BYTE_BUFFER_SIZE)
396 ACPI_WARN_PREDEFINED ((AE_INFO, Data->Pathname, Data->NodeFlags,
397 "Incorrect return buffer length %u, expected %u",
398 ReturnObject->Buffer.Length, ACPI_FDE_DWORD_BUFFER_SIZE));
400 return (AE_AML_OPERAND_TYPE);
403 /* Create the new (larger) buffer object */
405 BufferObject = AcpiUtCreateBufferObject (ACPI_FDE_DWORD_BUFFER_SIZE);
408 return (AE_NO_MEMORY);
411 /* Expand each byte to a DWORD */
413 ByteBuffer = ReturnObject->Buffer.Pointer;
414 DwordBuffer = ACPI_CAST_PTR (UINT32, BufferObject->Buffer.Pointer);
416 for (i = 0; i < ACPI_FDE_FIELD_COUNT; i++)
418 *DwordBuffer = (UINT32) *ByteBuffer;
423 ACPI_DEBUG_PRINT ((ACPI_DB_REPAIR,
424 "%s Expanded Byte Buffer to expected DWord Buffer\n",
429 return (AE_AML_OPERAND_TYPE);
432 /* Delete the original return object, return the new buffer object */
434 AcpiUtRemoveReference (ReturnObject);
435 *ReturnObjectPtr = BufferObject;
437 Data->Flags |= ACPI_OBJECT_REPAIRED;
442 /******************************************************************************
444 * FUNCTION: AcpiNsRepair_CID
446 * PARAMETERS: Data - Pointer to validation data structure
447 * ReturnObjectPtr - Pointer to the object returned from the
448 * evaluation of a method or object
450 * RETURN: Status. AE_OK if object is OK or was repaired successfully
452 * DESCRIPTION: Repair for the _CID object. If a string, ensure that all
453 * letters are uppercase and that there is no leading asterisk.
454 * If a Package, ensure same for all string elements.
456 *****************************************************************************/
460 ACPI_PREDEFINED_DATA *Data,
461 ACPI_OPERAND_OBJECT **ReturnObjectPtr)
464 ACPI_OPERAND_OBJECT *ReturnObject = *ReturnObjectPtr;
465 ACPI_OPERAND_OBJECT **ElementPtr;
466 ACPI_OPERAND_OBJECT *OriginalElement;
467 UINT16 OriginalRefCount;
471 /* Check for _CID as a simple string */
473 if (ReturnObject->Common.Type == ACPI_TYPE_STRING)
475 Status = AcpiNsRepair_HID (Data, ReturnObjectPtr);
479 /* Exit if not a Package */
481 if (ReturnObject->Common.Type != ACPI_TYPE_PACKAGE)
486 /* Examine each element of the _CID package */
488 ElementPtr = ReturnObject->Package.Elements;
489 for (i = 0; i < ReturnObject->Package.Count; i++)
491 OriginalElement = *ElementPtr;
492 OriginalRefCount = OriginalElement->Common.ReferenceCount;
494 Status = AcpiNsRepair_HID (Data, ElementPtr);
495 if (ACPI_FAILURE (Status))
500 /* Take care with reference counts */
502 if (OriginalElement != *ElementPtr)
504 /* Element was replaced */
506 (*ElementPtr)->Common.ReferenceCount =
509 AcpiUtRemoveReference (OriginalElement);
519 /******************************************************************************
521 * FUNCTION: AcpiNsRepair_HID
523 * PARAMETERS: Data - Pointer to validation data structure
524 * ReturnObjectPtr - Pointer to the object returned from the
525 * evaluation of a method or object
527 * RETURN: Status. AE_OK if object is OK or was repaired successfully
529 * DESCRIPTION: Repair for the _HID object. If a string, ensure that all
530 * letters are uppercase and that there is no leading asterisk.
532 *****************************************************************************/
536 ACPI_PREDEFINED_DATA *Data,
537 ACPI_OPERAND_OBJECT **ReturnObjectPtr)
539 ACPI_OPERAND_OBJECT *ReturnObject = *ReturnObjectPtr;
540 ACPI_OPERAND_OBJECT *NewString;
545 ACPI_FUNCTION_NAME (NsRepair_HID);
548 /* We only care about string _HID objects (not integers) */
550 if (ReturnObject->Common.Type != ACPI_TYPE_STRING)
555 if (ReturnObject->String.Length == 0)
557 ACPI_WARN_PREDEFINED ((AE_INFO, Data->Pathname, Data->NodeFlags,
558 "Invalid zero-length _HID or _CID string"));
560 /* Return AE_OK anyway, let driver handle it */
562 Data->Flags |= ACPI_OBJECT_REPAIRED;
566 /* It is simplest to always create a new string object */
568 NewString = AcpiUtCreateStringObject (ReturnObject->String.Length);
571 return (AE_NO_MEMORY);
575 * Remove a leading asterisk if present. For some unknown reason, there
576 * are many machines in the field that contains IDs like this.
578 * Examples: "*PNP0C03", "*ACPI0003"
580 Source = ReturnObject->String.Pointer;
584 NewString->String.Length--;
586 ACPI_DEBUG_PRINT ((ACPI_DB_REPAIR,
587 "%s: Removed invalid leading asterisk\n", Data->Pathname));
591 * Copy and uppercase the string. From the ACPI 5.0 specification:
593 * A valid PNP ID must be of the form "AAA####" where A is an uppercase
594 * letter and # is a hex digit. A valid ACPI ID must be of the form
595 * "NNNN####" where N is an uppercase letter or decimal digit, and
598 for (Dest = NewString->String.Pointer; *Source; Dest++, Source++)
600 *Dest = (char) ACPI_TOUPPER (*Source);
603 AcpiUtRemoveReference (ReturnObject);
604 *ReturnObjectPtr = NewString;
609 /******************************************************************************
611 * FUNCTION: AcpiNsRepair_TSS
613 * PARAMETERS: Data - Pointer to validation data structure
614 * ReturnObjectPtr - Pointer to the object returned from the
615 * evaluation of a method or object
617 * RETURN: Status. AE_OK if object is OK or was repaired successfully
619 * DESCRIPTION: Repair for the _TSS object. If necessary, sort the object list
620 * descending by the power dissipation values.
622 *****************************************************************************/
626 ACPI_PREDEFINED_DATA *Data,
627 ACPI_OPERAND_OBJECT **ReturnObjectPtr)
629 ACPI_OPERAND_OBJECT *ReturnObject = *ReturnObjectPtr;
631 ACPI_NAMESPACE_NODE *Node;
635 * We can only sort the _TSS return package if there is no _PSS in the
636 * same scope. This is because if _PSS is present, the ACPI specification
637 * dictates that the _TSS Power Dissipation field is to be ignored, and
638 * therefore some BIOSs leave garbage values in the _TSS Power field(s).
639 * In this case, it is best to just return the _TSS package as-is.
642 Status = AcpiNsGetNode (Data->Node, "^_PSS", ACPI_NS_NO_UPSEARCH, &Node);
643 if (ACPI_SUCCESS (Status))
648 Status = AcpiNsCheckSortedList (Data, ReturnObject, 5, 1,
649 ACPI_SORT_DESCENDING, "PowerDissipation");
655 /******************************************************************************
657 * FUNCTION: AcpiNsRepair_PSS
659 * PARAMETERS: Data - Pointer to validation data structure
660 * ReturnObjectPtr - Pointer to the object returned from the
661 * evaluation of a method or object
663 * RETURN: Status. AE_OK if object is OK or was repaired successfully
665 * DESCRIPTION: Repair for the _PSS object. If necessary, sort the object list
666 * by the CPU frequencies. Check that the power dissipation values
667 * are all proportional to CPU frequency (i.e., sorting by
668 * frequency should be the same as sorting by power.)
670 *****************************************************************************/
674 ACPI_PREDEFINED_DATA *Data,
675 ACPI_OPERAND_OBJECT **ReturnObjectPtr)
677 ACPI_OPERAND_OBJECT *ReturnObject = *ReturnObjectPtr;
678 ACPI_OPERAND_OBJECT **OuterElements;
679 UINT32 OuterElementCount;
680 ACPI_OPERAND_OBJECT **Elements;
681 ACPI_OPERAND_OBJECT *ObjDesc;
682 UINT32 PreviousValue;
688 * Entries (sub-packages) in the _PSS Package must be sorted by power
689 * dissipation, in descending order. If it appears that the list is
690 * incorrectly sorted, sort it. We sort by CpuFrequency, since this
691 * should be proportional to the power.
693 Status =AcpiNsCheckSortedList (Data, ReturnObject, 6, 0,
694 ACPI_SORT_DESCENDING, "CpuFrequency");
695 if (ACPI_FAILURE (Status))
701 * We now know the list is correctly sorted by CPU frequency. Check if
702 * the power dissipation values are proportional.
704 PreviousValue = ACPI_UINT32_MAX;
705 OuterElements = ReturnObject->Package.Elements;
706 OuterElementCount = ReturnObject->Package.Count;
708 for (i = 0; i < OuterElementCount; i++)
710 Elements = (*OuterElements)->Package.Elements;
711 ObjDesc = Elements[1]; /* Index1 = PowerDissipation */
713 if ((UINT32) ObjDesc->Integer.Value > PreviousValue)
715 ACPI_WARN_PREDEFINED ((AE_INFO, Data->Pathname, Data->NodeFlags,
716 "SubPackage[%u,%u] - suspicious power dissipation values",
720 PreviousValue = (UINT32) ObjDesc->Integer.Value;
728 /******************************************************************************
730 * FUNCTION: AcpiNsCheckSortedList
732 * PARAMETERS: Data - Pointer to validation data structure
733 * ReturnObject - Pointer to the top-level returned object
734 * ExpectedCount - Minimum length of each sub-package
735 * SortIndex - Sub-package entry to sort on
736 * SortDirection - Ascending or descending
737 * SortKeyName - Name of the SortIndex field
739 * RETURN: Status. AE_OK if the list is valid and is sorted correctly or
740 * has been repaired by sorting the list.
742 * DESCRIPTION: Check if the package list is valid and sorted correctly by the
743 * SortIndex. If not, then sort the list.
745 *****************************************************************************/
748 AcpiNsCheckSortedList (
749 ACPI_PREDEFINED_DATA *Data,
750 ACPI_OPERAND_OBJECT *ReturnObject,
751 UINT32 ExpectedCount,
756 UINT32 OuterElementCount;
757 ACPI_OPERAND_OBJECT **OuterElements;
758 ACPI_OPERAND_OBJECT **Elements;
759 ACPI_OPERAND_OBJECT *ObjDesc;
761 UINT32 PreviousValue;
764 ACPI_FUNCTION_NAME (NsCheckSortedList);
767 /* The top-level object must be a package */
769 if (ReturnObject->Common.Type != ACPI_TYPE_PACKAGE)
771 return (AE_AML_OPERAND_TYPE);
775 * NOTE: assumes list of sub-packages contains no NULL elements.
776 * Any NULL elements should have been removed by earlier call
777 * to AcpiNsRemoveNullElements.
779 OuterElements = ReturnObject->Package.Elements;
780 OuterElementCount = ReturnObject->Package.Count;
781 if (!OuterElementCount)
783 return (AE_AML_PACKAGE_LIMIT);
787 if (SortDirection == ACPI_SORT_DESCENDING)
789 PreviousValue = ACPI_UINT32_MAX;
792 /* Examine each subpackage */
794 for (i = 0; i < OuterElementCount; i++)
796 /* Each element of the top-level package must also be a package */
798 if ((*OuterElements)->Common.Type != ACPI_TYPE_PACKAGE)
800 return (AE_AML_OPERAND_TYPE);
803 /* Each sub-package must have the minimum length */
805 if ((*OuterElements)->Package.Count < ExpectedCount)
807 return (AE_AML_PACKAGE_LIMIT);
810 Elements = (*OuterElements)->Package.Elements;
811 ObjDesc = Elements[SortIndex];
813 if (ObjDesc->Common.Type != ACPI_TYPE_INTEGER)
815 return (AE_AML_OPERAND_TYPE);
819 * The list must be sorted in the specified order. If we detect a
820 * discrepancy, sort the entire list.
822 if (((SortDirection == ACPI_SORT_ASCENDING) &&
823 (ObjDesc->Integer.Value < PreviousValue)) ||
824 ((SortDirection == ACPI_SORT_DESCENDING) &&
825 (ObjDesc->Integer.Value > PreviousValue)))
827 AcpiNsSortList (ReturnObject->Package.Elements,
828 OuterElementCount, SortIndex, SortDirection);
830 Data->Flags |= ACPI_OBJECT_REPAIRED;
832 ACPI_DEBUG_PRINT ((ACPI_DB_REPAIR,
833 "%s: Repaired unsorted list - now sorted by %s\n",
834 Data->Pathname, SortKeyName));
838 PreviousValue = (UINT32) ObjDesc->Integer.Value;
846 /******************************************************************************
848 * FUNCTION: AcpiNsSortList
850 * PARAMETERS: Elements - Package object element list
851 * Count - Element count for above
852 * Index - Sort by which package element
853 * SortDirection - Ascending or Descending sort
857 * DESCRIPTION: Sort the objects that are in a package element list.
859 * NOTE: Assumes that all NULL elements have been removed from the package,
860 * and that all elements have been verified to be of type Integer.
862 *****************************************************************************/
866 ACPI_OPERAND_OBJECT **Elements,
871 ACPI_OPERAND_OBJECT *ObjDesc1;
872 ACPI_OPERAND_OBJECT *ObjDesc2;
873 ACPI_OPERAND_OBJECT *TempObj;
878 /* Simple bubble sort */
880 for (i = 1; i < Count; i++)
882 for (j = (Count - 1); j >= i; j--)
884 ObjDesc1 = Elements[j-1]->Package.Elements[Index];
885 ObjDesc2 = Elements[j]->Package.Elements[Index];
887 if (((SortDirection == ACPI_SORT_ASCENDING) &&
888 (ObjDesc1->Integer.Value > ObjDesc2->Integer.Value)) ||
890 ((SortDirection == ACPI_SORT_DESCENDING) &&
891 (ObjDesc1->Integer.Value < ObjDesc2->Integer.Value)))
893 TempObj = Elements[j-1];
894 Elements[j-1] = Elements[j];
895 Elements[j] = TempObj;