]> rtime.felk.cvut.cz Git - jailhouse.git/commitdiff
i8042: remove unreachable condition from if statement
authorHenning Schild <henning.schild@siemens.com>
Tue, 27 Jan 2015 14:05:28 +0000 (15:05 +0100)
committerJan Kiszka <jan.kiszka@siemens.com>
Sun, 1 Feb 2015 11:47:10 +0000 (12:47 +0100)
the size check was already done earlier in the function

Signed-off-by: Henning Schild <henning.schild@siemens.com>
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
hypervisor/arch/x86/i8042.c

index bdf732978ec93032a400bf3e461f30643e396184..cabed534120df3108744f689751559012cde55af 100644 (file)
@@ -35,7 +35,7 @@ int i8042_access_handler(struct registers *guest_regs, u16 port, bool dir_in,
                        guest_regs->rax |= inb(I8042_CMD_REG);
                } else {
                        val = (u8)guest_regs->rax;
-                       if (size != 1 || val == I8042_CMD_WRITE_CTRL_PORT ||
+                       if (val == I8042_CMD_WRITE_CTRL_PORT ||
                            (val & I8042_CMD_PULSE_CTRL_PORT) ==
                            I8042_CMD_PULSE_CTRL_PORT)
                                goto invalid_access;