]> rtime.felk.cvut.cz Git - hercules2020/nv-tegra/linux-4.4.git/commitdiff
media: i2c: IMX274: fix dotted line corruption
authorJosh Kuo <joshk@nvidia.com>
Fri, 27 Oct 2017 07:37:13 +0000 (15:37 +0800)
committermobile promotions <svcmobile_promotions@nvidia.com>
Wed, 8 Nov 2017 02:46:58 +0000 (18:46 -0800)
found dotted line corruption in the bottom of image if we do not
set correct value of VWIDCUT.

The Veff is 2174, then VWIDCUT should be (2174-2160)/2 = 7.

Bug 200357770

Change-Id: If969c34329a51ff980030adcca9aa8b3fc945d4e
Signed-off-by: Josh Kuo <joshk@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1586800
Reviewed-by: Automatic_Commit_Validation_User
GVS: Gerrit_Virtual_Submit
Reviewed-by: Esen Chen <esenc@nvidia.com>
Reviewed-by: Josh Kergan <jkergan@nvidia.com>
Reviewed-by: Nathan Lord <nlord@nvidia.com>
Reviewed-by: Shantanu Nath <snath@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
drivers/media/i2c/imx274_mode_tbls.h

index f1ed8ab32038ac5ffa972ca05cf341683aa4a060..e0fe1859c69b074d3a6f07a997864e5d8d544ab9 100644 (file)
@@ -110,7 +110,7 @@ static const imx274_reg mode_3840X2160[] = {
 
        /* crop */
        {0x30DD, 0x01}, /*VWIDCUTEN*/
-       {0x30DE, 0x08}, /*VWIDCUT*/
+       {0x30DE, 0x07}, /*VWIDCUT*/
        {0x30E0, 0x00}, /*VWINCUTPOS*/
        {0x3037, 0x01}, /*HTRIMMING_EN*/
        {0x3038, 0x0C}, /*HTRIMMING_START*/
@@ -207,7 +207,7 @@ static const imx274_reg mode_3840X2160_60fps[] = {
 
        /* crop */
        {0x30DD, 0x01}, /*VWIDCUTEN*/
-       {0x30DE, 0x08}, /*VWIDCUT*/
+       {0x30DE, 0x07}, /*VWIDCUT*/
        {0x30E0, 0x00}, /*VWINCUTPOS*/
        {0x3037, 0x01}, /*HTRIMMING_EN*/
        {0x3038, 0x0C}, /*HTRIMMING_START*/
@@ -219,7 +219,7 @@ static const imx274_reg mode_3840X2160_60fps[] = {
        {0x3004, 0x01},
        {0x3005, 0x01},
        {0x3006, 0x00},
-       {0x3007, 0x02},
+       {0x3007, 0xA2},
        {0x3A41, 0x08},
        {0x3A42, 0x01},
        {0x3342, 0x0A},