]> rtime.felk.cvut.cz Git - hercules2020/nv-tegra/linux-4.4.git/commitdiff
misc: nvs: Fix coverity defect in dfsh driver
authorAkhilesh Reddy Khumbum <akhumbum@nvidia.com>
Tue, 31 Jan 2017 21:44:11 +0000 (13:44 -0800)
committermobile promotions <svcmobile_promotions@nvidia.com>
Wed, 1 Feb 2017 21:33:52 +0000 (13:33 -0800)
* Comment the logically dead code.

Coverity ID: 489612
Bug 200192580

Change-Id: I61883779a17c4606009b154a95a113cc58c6775c
Signed-off-by: Akhilesh Reddy Khumbum <akhumbum@nvidia.com>
Reviewed-on: http://git-master/r/1296844
GVS: Gerrit_Virtual_Submit
Reviewed-by: svccoveritychecker <svccoveritychecker@nvidia.com>
Reviewed-by: Robert Collins <rcollins@nvidia.com>
drivers/misc/nvs-dfsh/nvs_dfsh.c

index d9b73032d660dd59fc8f7f3e74739af8fbb4dd20..a703715825ab75387f0f85f04e5bf7291159378d 100644 (file)
@@ -439,14 +439,14 @@ static int dfsh_enable(void *client, int snsr_id, int enable)
                        /* if individual sensor enable is supported then here
                         * we want to send the sensor enable message to DFSH.
                         */
-                       /* ret = dfsh_en(st, snsr_id); */
-                       if (ret < 0) {
-                               if (!st->enabled[snsr_id])
-                                       dfsh_disable(st, snsr_id);
-                       } else {
-                               st->enabled[snsr_id] = enable;
-                               st->enabled_msk |= (1 << snsr_id);
-                       }
+                       /* ret = dfsh_en(st, snsr_id);
+                        * if (ret < 0) {
+                        *      if (!st->enabled[snsr_id])
+                        *              dfsh_disable(st, snsr_id);
+                        * } else {
+                        */
+                       st->enabled[snsr_id] = enable;
+                       st->enabled_msk |= (1 << snsr_id);
                }
        } else {
                ret = dfsh_disable(st, snsr_id);