]> rtime.felk.cvut.cz Git - coffee/buildroot.git/commitdiff
ushare: do not allow building in static lib situations
authorThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Sun, 23 Nov 2014 17:36:01 +0000 (18:36 +0100)
committerThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Mon, 24 Nov 2014 21:04:29 +0000 (22:04 +0100)
The ushare configure script is a custom shell script, and it is not
designed to understand that the library order is important when doing
static linking.

Fixes:

  http://autobuild.buildroot.org/results/32e/32ed2a521043f929cc290145c8a651e69042e104/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
package/ushare/Config.in

index 981f0812d164f18c9a86b77079db97a6ae0a78db..d961434016ad89df5468048a57244d42dfc31e28 100644 (file)
@@ -4,6 +4,10 @@ config BR2_PACKAGE_USHARE
        depends on BR2_TOOLCHAIN_HAS_THREADS # libupnp
        select BR2_PACKAGE_LIBUPNP
        select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
+       # ushare has a completely custom configure script that does
+       # broken things with library ordering, which breaks static
+       # linking.
+       depends on !BR2_PREFER_STATIC_LIB
        help
          uShare is a UPnP (TM) A/V & DLNA Media Server.
          It implements the server component that provides UPnP media devices
@@ -11,5 +15,6 @@ config BR2_PACKAGE_USHARE
 
          http://ushare.geexbox.org/
 
-comment "ushare needs a toolchain w/ largefile, threads"
-       depends on !(BR2_LARGEFILE && BR2_TOOLCHAIN_HAS_THREADS)
+comment "ushare needs a toolchain w/ largefile, threads, dynamic library"
+       depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS || \
+               BR2_PREFER_STATIC_LIB