]> rtime.felk.cvut.cz Git - coffee/buildroot.git/commitdiff
pkg-download.mk: do not add a trailing slash to <PKG>_SITE
authorPeter Korsgaard <peter@korsgaard.com>
Wed, 4 Apr 2018 06:30:51 +0000 (08:30 +0200)
committerPeter Korsgaard <peter@korsgaard.com>
Thu, 5 Apr 2018 06:34:36 +0000 (08:34 +0200)
Fixes
http://autobuild.buildroot.net/results/734/7342b25f01d60cafc4a5422a5a1c282629f361c5/

$(dir does not strip last path separator and the wget wrapper adds a '/'
between the -u argument and the filename when it reconstructs the URL,
leading us to have two slashes before the filename when accessing the
upstream location.

Most upstream servers ignores this, but not all - Leading to download issues
from pypi.

Notice: As pointed out by Arnout, we cannot simply use $(PKG)_SITE here as
_PATCH and _EXTRA_DOWNLOADS may contain full URLs.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
package/pkg-download.mk

index 7ed95f2b2c170692b4bf6b05efc90062a65da878..2c4ad3ba2cda13ba78ef714edab28e88aace7a9f 100644 (file)
@@ -82,7 +82,7 @@ endif
 
 ifeq ($(BR2_PRIMARY_SITE_ONLY),)
 DOWNLOAD_URIS += \
-       -u $($(PKG)_SITE_METHOD)+$(dir $(call qstrip,$(1)))
+       -u $($(PKG)_SITE_METHOD)+$(patsubst %/,%,$(dir $(call qstrip,$(1))))
 ifneq ($(call qstrip,$(BR2_BACKUP_SITE)),)
 DOWNLOAD_URIS += \
        -u $(call getschemeplusuri,$(call qstrip,$(BR2_BACKUP_SITE)/$($(PKG)_DL_SUBDIR)),urlencode) \