platform: nvadsp: Fix Uninitialized pointer read

Fix Coverity issue of Uninitialized pointer read in adsp_logger_open.
Coverity id : 28195

Bug 1416640

Change-Id: I14f0bda0ff92de646a20f3796cfdcf0d3cd2305c
Signed-off-by: Ajay Nandakumar <anandakumarm@nvidia.com>
Reviewed-on: http://git-master/r/604775
Reviewed-by: Sachin Nikam <snikam@nvidia.com>
Tested-by: Sachin Nikam <snikam@nvidia.com>

diff --git a/drivers/platform/tegra/nvadsp/os.c b/drivers/platform/tegra/nvadsp/os.c
index 5fba5f4d3b0e44faac511f43b3d3a85a72524c6d..d64d652d15e8b9dda5aabef308447f63701837c3 100644 (file)
--- a/drivers/platform/tegra/nvadsp/os.c
+++ b/drivers/platform/tegra/nvadsp/os.c
@@ -133,8 +133,8 @@ static int adsp_logger_open(struct inode *inode, struct file *file)
        /* loop till writer is initilized with SOH */
        do {
                msleep(20);
-               if (!IS_ERR_OR_NULL(logger->debug_ram_rdr))
-                       start = strchr(logger->debug_ram_rdr, SOH);
+               start = !IS_ERR_OR_NULL(logger->debug_ram_rdr) ?
+                               strchr(logger->debug_ram_rdr, SOH) : NULL;
        } while (!start);
 
        /* maxdiff can be 0, therefore valid */