]> rtime.felk.cvut.cz Git - sojka/lightdm.git/commitdiff
Remove MirServer class and connect Mir sessions directly to UnitySystemCompositor
authorRobert Ancell <robert.ancell@canonical.com>
Sun, 19 Jun 2016 22:43:19 +0000 (10:43 +1200)
committerRobert Ancell <robert.ancell@canonical.com>
Sun, 19 Jun 2016 22:43:19 +0000 (10:43 +1200)
13 files changed:
src/Makefile.am
src/display-server.c
src/display-server.h
src/mir-server.c [deleted file]
src/mir-server.h [deleted file]
src/seat-unity.c
src/seat.c
src/seat.h
src/session.c
src/session.h
src/unity-system-compositor.c
src/x-server-xmir.c
tests/scripts/unity-mir-script-hooks.conf

index d519e6389d9a268bc290b3f73c76e1c86fb84121..dc6d40dcf189c57c1478c68e75f77f2a007b9617 100644 (file)
@@ -23,8 +23,6 @@ lightdm_SOURCES = \
        login1.h \
        log-file.c \
        log-file.h \
-       mir-server.c \
-       mir-server.h \
        plymouth.c \
        plymouth.h \
        process.c \
index 2e48a09ee6c06563879cb21998d157cd63821380..fb919ebe053f0cac7bffad202fea4645987ce421 100644 (file)
@@ -62,6 +62,18 @@ display_server_get_session_type (DisplayServer *server)
     return DISPLAY_SERVER_GET_CLASS (server)->get_session_type (server);
 }
 
+DisplayServer *
+display_server_get_parent (DisplayServer *server)
+{
+    return DISPLAY_SERVER_GET_CLASS (server)->get_parent (server);
+}
+
+static DisplayServer *
+display_server_real_get_parent (DisplayServer *server)
+{
+    return NULL;
+}
+
 gboolean
 display_server_get_can_share (DisplayServer *server)
 {
@@ -177,6 +189,7 @@ display_server_class_init (DisplayServerClass *klass)
 {
     GObjectClass *object_class = G_OBJECT_CLASS (klass);
 
+    klass->get_parent = display_server_real_get_parent;  
     klass->get_can_share = display_server_real_get_can_share;
     klass->get_vt = display_server_real_get_vt;
     klass->start = display_server_real_start;
index 00e9e26f1c2b43e9d5c5d59abaf1f75fd73d65e9..7a85321d2b31ed1e21b63b7e9824516f35b949a5 100644 (file)
@@ -44,6 +44,7 @@ typedef struct
     void (*ready)(DisplayServer *server);
     void (*stopped)(DisplayServer *server);
 
+    DisplayServer *(*get_parent)(DisplayServer *server);  
     const gchar *(*get_session_type)(DisplayServer *server);
     gboolean (*get_can_share)(DisplayServer *server);
     gint (*get_vt)(DisplayServer *server);
@@ -61,6 +62,8 @@ const gchar *display_server_get_name (DisplayServer *server);
 
 const gchar *display_server_get_session_type (DisplayServer *server);
 
+DisplayServer *display_server_get_parent (DisplayServer *server);
+
 gboolean display_server_get_can_share (DisplayServer *server);
 
 gint display_server_get_vt (DisplayServer *server);
diff --git a/src/mir-server.c b/src/mir-server.c
deleted file mode 100644 (file)
index 5acca00..0000000
+++ /dev/null
@@ -1,124 +0,0 @@
-/*
- * Copyright (C) 2010-2011 Robert Ancell.
- * Author: Robert Ancell <robert.ancell@canonical.com>
- *
- * This program is free software: you can redistribute it and/or modify it under
- * the terms of the GNU General Public License as published by the Free Software
- * Foundation, either version 3 of the License, or (at your option) any later
- * version. See http://www.gnu.org/copyleft/gpl.html the full text of the
- * license.
- */
-
-#include <string.h>
-
-#include "mir-server.h"
-#include "configuration.h"
-#include "vt.h"
-
-struct MirServerPrivate
-{
-    /* VT to run on */
-    gint vt;
-
-    /* Mir socket for this server to talk to parent */
-    gchar *parent_socket;
-};
-
-G_DEFINE_TYPE (MirServer, mir_server, DISPLAY_SERVER_TYPE);
-
-MirServer *mir_server_new (void)
-{
-    return g_object_new (MIR_SERVER_TYPE, NULL);
-}
-
-void
-mir_server_set_vt (MirServer *server, gint vt)
-{
-    g_return_if_fail (server != NULL);
-    if (server->priv->vt > 0)
-        vt_unref (server->priv->vt);
-    server->priv->vt = vt;
-    if (vt > 0)
-        vt_ref (vt);
-}
-
-void
-mir_server_set_parent_socket (MirServer *server, const gchar *parent_socket)
-{
-    g_return_if_fail (server != NULL);
-    g_free (server->priv->parent_socket);
-    server->priv->parent_socket = g_strdup (parent_socket);
-}
-
-static const gchar *
-mir_server_get_session_type (DisplayServer *server)
-{
-    return "mir";
-}
-
-static gint
-mir_server_get_vt (DisplayServer *server)
-{
-    return MIR_SERVER (server)->priv->vt;
-}
-
-static void
-mir_server_connect_session (DisplayServer *display_server, Session *session)
-{
-    MirServer *server;
-
-    session_set_env (session, "XDG_SESSION_TYPE", "mir");
-
-    server = MIR_SERVER (display_server);
-    if (server->priv->parent_socket)
-        session_set_env (session, "MIR_SERVER_HOST_SOCKET", server->priv->parent_socket);
-    if (server->priv->vt > 0)
-    {
-        gchar *value = g_strdup_printf ("%d", server->priv->vt);
-        session_set_env (session, "XDG_VTNR", value);
-        g_free (value);
-    }
-}
-
-static void
-mir_server_disconnect_session (DisplayServer *display_server, Session *session)
-{
-    session_unset_env (session, "XDG_SESSION_TYPE");
-    session_unset_env (session, "MIR_SERVER_HOST_SOCKET");
-    session_unset_env (session, "XDG_VTNR");
-}
-
-static void
-mir_server_init (MirServer *server)
-{
-    server->priv = G_TYPE_INSTANCE_GET_PRIVATE (server, MIR_SERVER_TYPE, MirServerPrivate);
-    server->priv->vt = -1;
-    display_server_set_name (DISPLAY_SERVER (server), "mir");
-}
-
-static void
-mir_server_finalize (GObject *object)
-{
-    MirServer *self = MIR_SERVER (object);
-
-    if (self->priv->vt > 0)
-        vt_unref (self->priv->vt);
-    g_free (self->priv->parent_socket);
-
-    G_OBJECT_CLASS (mir_server_parent_class)->finalize (object);
-}
-
-static void
-mir_server_class_init (MirServerClass *klass)
-{
-    GObjectClass *object_class = G_OBJECT_CLASS (klass);
-    DisplayServerClass *display_server_class = DISPLAY_SERVER_CLASS (klass);
-
-    display_server_class->get_session_type = mir_server_get_session_type;
-    display_server_class->get_vt = mir_server_get_vt;
-    display_server_class->connect_session = mir_server_connect_session;
-    display_server_class->disconnect_session = mir_server_disconnect_session;
-    object_class->finalize = mir_server_finalize;
-
-    g_type_class_add_private (klass, sizeof (MirServerPrivate));
-}
diff --git a/src/mir-server.h b/src/mir-server.h
deleted file mode 100644 (file)
index 4f59623..0000000
+++ /dev/null
@@ -1,49 +0,0 @@
-/*
- * Copyright (C) 2010-2011 Robert Ancell.
- * Author: Robert Ancell <robert.ancell@canonical.com>
- *
- * This program is free software: you can redistribute it and/or modify it under
- * the terms of the GNU General Public License as published by the Free Software
- * Foundation, either version 3 of the License, or (at your option) any later
- * version. See http://www.gnu.org/copyleft/gpl.html the full text of the
- * license.
- */
-
-#ifndef MIR_SERVER_H_
-#define MIR_SERVER_H_
-
-#include <glib-object.h>
-#include "display-server.h"
-
-G_BEGIN_DECLS
-
-#define MIR_SERVER_TYPE (mir_server_get_type())
-#define MIR_SERVER(obj) (G_TYPE_CHECK_INSTANCE_CAST ((obj), MIR_SERVER_TYPE, MirServer))
-#define MIR_SERVER_CLASS(klass)   (G_TYPE_CHECK_CLASS_CAST ((klass), MIR_SERVER_TYPE, MirServerClass))
-#define MIR_SERVER_GET_CLASS(obj) (G_TYPE_INSTANCE_GET_CLASS ((obj), MIR_SERVER_TYPE, MirServerClass))
-#define IS_MIR_SERVER(obj) (G_TYPE_CHECK_INSTANCE_TYPE ((obj), MIR_SERVER_TYPE))
-
-typedef struct MirServerPrivate MirServerPrivate;
-
-typedef struct
-{
-    DisplayServer     parent_instance;
-    MirServerPrivate *priv;
-} MirServer;
-
-typedef struct
-{
-    DisplayServerClass parent_class;
-} MirServerClass;
-
-GType mir_server_get_type (void);
-
-MirServer *mir_server_new (void);
-
-void mir_server_set_vt (MirServer *server, gint vt);
-
-void mir_server_set_parent_socket (MirServer *server, const gchar *parent_socket);
-
-G_END_DECLS
-
-#endif /* MIR_SERVER_H_ */
index 3df0aa531839fcde69697574e90e5850fb98ae6a..c9a5ad6b8f5dc17c9a6292f6a94cb57cb36ff827 100644 (file)
@@ -18,7 +18,6 @@
 #include "configuration.h"
 #include "unity-system-compositor.h"
 #include "x-server-xmir.h"
-#include "mir-server.h"
 #include "vt.h"
 #include "plymouth.h"
 
@@ -30,10 +29,8 @@ struct SeatUnityPrivate
     /* X server being used for XDMCP */
     XServerXmir *xdmcp_x_server;
 
-    /* Next Mir ID to use for a Mir sessions, X server and greeters */
-    gint next_session_id;
+    /* Next Mir ID to use for a Xmir servers */
     gint next_x_server_id;
-    gint next_greeter_id;
 
     /* The currently visible session */
     Session *active_session;
@@ -235,18 +232,6 @@ create_x_server (Seat *seat)
     return x_server;
 }
 
-static DisplayServer *
-create_mir_server (Seat *seat)
-{
-    MirServer *mir_server;
-
-    mir_server = mir_server_new ();
-    mir_server_set_parent_socket (mir_server, unity_system_compositor_get_socket (SEAT_UNITY (seat)->priv->compositor));
-    mir_server_set_vt (mir_server, display_server_get_vt (DISPLAY_SERVER (SEAT_UNITY (seat)->priv->compositor)));
-
-    return DISPLAY_SERVER (mir_server);
-}
-
 static DisplayServer *
 seat_unity_create_display_server (Seat *seat, Session *session)
 {
@@ -256,7 +241,7 @@ seat_unity_create_display_server (Seat *seat, Session *session)
     if (strcmp (session_type, "x") == 0)
         return DISPLAY_SERVER (create_x_server (seat));
     else if (strcmp (session_type, "mir") == 0)
-        return create_mir_server (seat);
+        return g_object_ref (SEAT_UNITY (seat)->priv->compositor);
     else
     {
         l_warning (seat, "Can't create unsupported display server '%s'", session_type);
@@ -264,21 +249,24 @@ seat_unity_create_display_server (Seat *seat, Session *session)
     }
 }
 
+static gboolean
+seat_unity_display_server_is_used (Seat *seat, DisplayServer *display_server)
+{
+    if (display_server == DISPLAY_SERVER (SEAT_UNITY (seat)->priv->compositor))
+        return TRUE;
+
+    return SEAT_CLASS (seat_unity_parent_class)->display_server_is_used (seat, display_server);
+}
+
 static GreeterSession *
 seat_unity_create_greeter_session (Seat *seat)
 {
     GreeterSession *greeter_session;
-    gchar *id;
     gint vt;
 
     greeter_session = SEAT_CLASS (seat_unity_parent_class)->create_greeter_session (seat);
     session_set_env (SESSION (greeter_session), "XDG_SEAT", seat_get_name (seat));
 
-    id = g_strdup_printf ("greeter-%d", SEAT_UNITY (seat)->priv->next_greeter_id);
-    SEAT_UNITY (seat)->priv->next_greeter_id++;
-    session_set_env (SESSION (greeter_session), "MIR_SERVER_NAME", id);
-    g_free (id);
-
     vt = display_server_get_vt (DISPLAY_SERVER (SEAT_UNITY (seat)->priv->compositor));
     if (vt >= 0)
     {
@@ -294,17 +282,11 @@ static Session *
 seat_unity_create_session (Seat *seat)
 {
     Session *session;
-    gchar *id;
     gint vt;
 
     session = SEAT_CLASS (seat_unity_parent_class)->create_session (seat);
     session_set_env (session, "XDG_SEAT", seat_get_name (seat));
 
-    id = g_strdup_printf ("session-%d", SEAT_UNITY (seat)->priv->next_session_id);
-    SEAT_UNITY (seat)->priv->next_session_id++;
-    session_set_env (session, "MIR_SERVER_NAME", id);
-    g_free (id);
-
     vt = display_server_get_vt (DISPLAY_SERVER (SEAT_UNITY (seat)->priv->compositor));
     if (vt >= 0)
     {
@@ -316,37 +298,39 @@ seat_unity_create_session (Seat *seat)
     return session;
 }
 
-static void
-seat_unity_set_active_session (Seat *seat, Session *session)
+static const gchar *
+get_mir_id (Session *session)
 {
     DisplayServer *display_server;
 
-    if (session == SEAT_UNITY (seat)->priv->active_session)
-        return;
-    SEAT_UNITY (seat)->priv->active_session = g_object_ref (session);
+    if (!session)
+        return NULL;
 
-    display_server = session_get_display_server (session);
-    if (SEAT_UNITY (seat)->priv->active_display_server != display_server)
-    {
-        const gchar *id = NULL;
+    display_server = session_get_display_server (session);  
+    if (IS_UNITY_SYSTEM_COMPOSITOR (display_server))
+        return session_get_env (session, "MIR_SERVER_NAME");
+    if (IS_X_SERVER_XMIR (display_server))
+        return x_server_xmir_get_mir_id (X_SERVER_XMIR (display_server));
 
-        SEAT_UNITY (seat)->priv->active_display_server = g_object_ref (display_server);
+    return NULL;
+}
 
-        if (IS_X_SERVER_LOCAL (display_server))
-            id = x_server_xmir_get_mir_id (X_SERVER_XMIR (display_server));
-        else
-            id = session_get_env (session, "MIR_SERVER_NAME");
+static void
+seat_unity_set_active_session (Seat *s, Session *session)
+{
+    SeatUnity *seat = SEAT_UNITY (s);
+    const gchar *old_id, *new_id;
 
-        if (id)
-        {
-            l_debug (seat, "Switching to Mir session %s", id);
-            unity_system_compositor_set_active_session (SEAT_UNITY (seat)->priv->compositor, id);
-        }
-        else
-            l_warning (seat, "Failed to work out session ID");
-    }
+    old_id = get_mir_id (seat->priv->active_session);
+    new_id = get_mir_id (session);
+
+    g_clear_object (&seat->priv->active_session);
+    seat->priv->active_session = g_object_ref (session);
+
+    if (g_strcmp0 (old_id, new_id) != 0)
+        unity_system_compositor_set_active_session (seat->priv->compositor, new_id);
 
-    SEAT_CLASS (seat_unity_parent_class)->set_active_session (seat, session);
+    SEAT_CLASS (seat_unity_parent_class)->set_active_session (s, session);
 }
 
 static Session *
@@ -448,6 +432,7 @@ seat_unity_class_init (SeatUnityClass *klass)
     seat_class->setup = seat_unity_setup;
     seat_class->start = seat_unity_start;
     seat_class->create_display_server = seat_unity_create_display_server;
+    seat_class->display_server_is_used = seat_unity_display_server_is_used;
     seat_class->create_greeter_session = seat_unity_create_greeter_session;
     seat_class->create_session = seat_unity_create_session;
     seat_class->set_active_session = seat_unity_set_active_session;
index 6dc1a0eaeb9d6b678675500e51b6a0b5972baf2c..01bda3826a5d2a8cfd9a49292de4b0dde20462d7 100644 (file)
@@ -85,6 +85,7 @@ static GHashTable *seat_modules = NULL;
 
 // FIXME: Make a get_display_server() that re-uses display servers if supported
 static DisplayServer *create_display_server (Seat *seat, Session *session);
+static gboolean start_display_server (Seat *seat, DisplayServer *display_server);
 static GreeterSession *create_greeter_session (Seat *seat);
 static void start_session (Seat *seat, Session *session);
 
@@ -596,7 +597,7 @@ switch_to_greeter_from_failed_session (Seat *seat, Session *session)
 
             display_server = create_display_server (seat, session);
             session_set_display_server (session, display_server);
-            if (!display_server_start (display_server))
+            if (!start_display_server (seat, display_server))
             {
                 l_debug (seat, "Failed to start display server for greeter");
                 seat_stop (seat);
@@ -866,24 +867,11 @@ session_stopped_cb (Session *session, Seat *seat)
     }
 
     /* Stop the display server if no-longer required */
-    if (display_server && !display_server_get_is_stopping (display_server))
+    if (display_server && !display_server_get_is_stopping (display_server) &&
+        !SEAT_GET_CLASS (seat)->display_server_is_used (seat, display_server))
     {
-        GList *link;
-        int n_sessions = 0;
-
-        for (link = seat->priv->sessions; link; link = link->next)
-        {
-            Session *s = link->data;
-            if (s == session)
-                continue;
-            if (session_get_display_server (s) == display_server)
-                n_sessions++;
-        }
-        if (n_sessions == 0)
-        {
-            l_debug (seat, "Stopping display server, no sessions require it");
-            display_server_stop (display_server);
-        }
+        l_debug (seat, "Stopping display server, no sessions require it");
+        display_server_stop (display_server);
     }
 
     g_signal_emit (seat, signals[SESSION_REMOVED], 0, session);
@@ -1282,7 +1270,7 @@ greeter_start_session_cb (Greeter *greeter, SessionType type, const gchar *sessi
     {
         display_server = create_display_server (seat, session);
         session_set_display_server (session, display_server);
-        if (!display_server_start (display_server))
+        if (!start_display_server (seat, display_server))
         {
             l_debug (seat, "Failed to start display server for new session");
             return FALSE;
@@ -1391,7 +1379,10 @@ find_session_for_display_server (Seat *seat, DisplayServer *display_server)
     for (link = seat->priv->sessions; link; link = link->next)
     {
         Session *session = link->data;
-        if (session_get_display_server (session) == display_server && !session_get_is_stopping (session))
+
+        if (session_get_display_server (session) == display_server &&
+            !session_get_is_stopping (session) &&
+            !session_get_is_run (session))
             return session;
     }
 
@@ -1448,13 +1439,29 @@ create_display_server (Seat *seat, Session *session)
     if (!display_server)
         return NULL;
 
-    seat->priv->display_servers = g_list_append (seat->priv->display_servers, display_server);
-    g_signal_connect (display_server, DISPLAY_SERVER_SIGNAL_READY, G_CALLBACK (display_server_ready_cb), seat);
-    g_signal_connect (display_server, DISPLAY_SERVER_SIGNAL_STOPPED, G_CALLBACK (display_server_stopped_cb), seat);
+    /* Remember this display server */
+    if (!g_list_find (seat->priv->display_servers, display_server)) 
+    {
+        seat->priv->display_servers = g_list_append (seat->priv->display_servers, display_server);
+        g_signal_connect (display_server, DISPLAY_SERVER_SIGNAL_READY, G_CALLBACK (display_server_ready_cb), seat);
+        g_signal_connect (display_server, DISPLAY_SERVER_SIGNAL_STOPPED, G_CALLBACK (display_server_stopped_cb), seat);
+    }
 
     return display_server;
 }
 
+static gboolean
+start_display_server (Seat *seat, DisplayServer *display_server)
+{
+    if (display_server_get_is_ready (display_server))
+    {
+        display_server_ready_cb (display_server, seat);
+        return TRUE;
+    }
+    else
+        return display_server_start (display_server);
+}
+
 gboolean
 seat_switch_to_greeter (Seat *seat)
 {
@@ -1485,7 +1492,7 @@ seat_switch_to_greeter (Seat *seat)
     display_server = create_display_server (seat, SESSION (greeter_session));
     session_set_display_server (SESSION (greeter_session), display_server);
 
-    return display_server_start (display_server);
+    return start_display_server (seat, display_server);
 }
 
 static void
@@ -1516,7 +1523,7 @@ switch_authentication_complete_cb (Session *session, Seat *seat)
             seat->priv->session_to_activate = g_object_ref (session);
             display_server = create_display_server (seat, session);
             session_set_display_server (session, display_server);
-            display_server_start (display_server);
+            start_display_server (seat, display_server);
         }
 
         return;
@@ -1556,7 +1563,7 @@ switch_authentication_complete_cb (Session *session, Seat *seat)
 
         display_server = create_display_server (seat, SESSION (greeter_session));
         session_set_display_server (SESSION (greeter_session), display_server);
-        display_server_start (display_server);
+        start_display_server (seat, display_server);
     }
 }
 
@@ -1632,7 +1639,7 @@ seat_switch_to_guest (Seat *seat, const gchar *session_name)
     session_set_pam_service (session, seat_get_string_property (seat, "pam-autologin-service"));
     session_set_display_server (session, display_server);
 
-    return display_server_start (display_server);
+    return start_display_server (seat, display_server);
 }
 
 gboolean
@@ -1708,7 +1715,7 @@ seat_lock (Seat *seat, const gchar *username)
             return TRUE;
         }
         else
-            return display_server_start (display_server);
+            return start_display_server (seat, display_server);
     }
 }
 
@@ -1781,7 +1788,7 @@ seat_real_start (Seat *seat)
 
             display_server = create_display_server (seat, session);
             session_set_display_server (session, display_server);
-            if (!display_server || !display_server_start (display_server))
+            if (!display_server || !start_display_server (seat, display_server))
             {
                 l_debug (seat, "Can't create display server for automatic login");
                 session_stop (session);
@@ -1811,7 +1818,7 @@ seat_real_start (Seat *seat)
 
         display_server = create_display_server (seat, session);
         session_set_display_server (session, display_server);
-        if (!display_server || !display_server_start (display_server))
+        if (!display_server || !start_display_server (seat, display_server))
         {
             l_debug (seat, "Can't create display server for greeter");
             session_stop (session);
@@ -1835,13 +1842,37 @@ seat_real_start (Seat *seat)
 
         background_display_server = create_display_server (seat, background_session);
         session_set_display_server (background_session, background_display_server);
-        if (!display_server_start (background_display_server))
+        if (!start_display_server (seat, background_display_server))
             l_warning (seat, "Failed to start display server for background session");
     }
 
     return TRUE;
 }
 
+static DisplayServer *
+seat_real_create_display_server (Seat *seat, Session *session)
+{
+    return NULL;
+}
+
+static gboolean
+seat_real_display_server_is_used (Seat *seat, DisplayServer *display_server)
+{
+    GList *link;
+
+    for (link = seat->priv->sessions; link; link = link->next)
+    {
+        Session *session = link->data;
+        DisplayServer *d;
+
+        d = session_get_display_server (session);
+        if (d == display_server || display_server_get_parent (d) == display_server)
+            return TRUE;
+    }
+
+    return FALSE;
+}
+
 static GreeterSession *
 seat_real_create_greeter_session (Seat *seat)
 {
@@ -1952,6 +1983,8 @@ seat_class_init (SeatClass *klass)
 
     klass->setup = seat_real_setup;
     klass->start = seat_real_start;
+    klass->create_display_server = seat_real_create_display_server;
+    klass->display_server_is_used = seat_real_display_server_is_used;  
     klass->create_greeter_session = seat_real_create_greeter_session;
     klass->create_session = seat_real_create_session;
     klass->set_active_session = seat_real_set_active_session;
index 308b68915c7654fda4e1734934a954dbdad1a4d7..3c5b3ee956ed57dd734b6f3186b1b0bc5bb76403 100644 (file)
@@ -46,7 +46,7 @@ typedef struct
     void (*setup)(Seat *seat);
     gboolean (*start)(Seat *seat);
     DisplayServer *(*create_display_server) (Seat *seat, Session *session);
-    gboolean (*display_server_supports_session_type) (Seat *seat, DisplayServer *display_server, const gchar *session_type);
+    gboolean (*display_server_is_used) (Seat *seat, DisplayServer *display_server);
     GreeterSession *(*create_greeter_session) (Seat *seat);
     Session *(*create_session) (Seat *seat);
     void (*set_active_session)(Seat *seat, Session *session);
index 3c7a34bd91dde310ce83f0865596429a2779e583..86cc0ae6c77a4ead70427cf0b77a2136267e3fc2 100644 (file)
@@ -735,10 +735,18 @@ session_get_authentication_result_string (Session *session)
 void
 session_run (Session *session)
 {
+    g_return_if_fail (session != NULL);
     g_return_if_fail (session->priv->display_server != NULL);
     return SESSION_GET_CLASS (session)->run (session);
 }
 
+gboolean
+session_get_is_run (Session *session)
+{
+    g_return_val_if_fail (session != NULL, FALSE);
+    return session->priv->command_run;
+}
+
 static void
 session_real_run (Session *session)
 {
@@ -807,7 +815,6 @@ session_real_run (Session *session)
     write_data (session, &argc, sizeof (argc));
     for (link = session->priv->env; link; link = link->next)
         write_string (session, (gchar *) link->data);
-
     argc = g_strv_length (session->priv->argv);
     write_data (session, &argc, sizeof (argc));
     for (i = 0; i < argc; i++)
index 800d0a7121608e3f473936997f321a4e2b8344e5..5f57885a31c852a9778e43a1c83d469af7c88c74 100644 (file)
@@ -136,6 +136,8 @@ const gchar *session_get_authentication_result_string (Session *session);
 
 void session_run (Session *session);
 
+gboolean session_get_is_run (Session *session);
+
 void session_lock (Session *session);
 
 void session_unlock (Session *session);
index 9991257d958ec08eef2d2418a5fe7594c3736f18..c3fa5d401e09bf35cb8de8dee753ce8c11b1ab84 100644 (file)
@@ -58,6 +58,10 @@ struct UnitySystemCompositorPrivate
 
     /* TRUE when received ready signal */
     gboolean is_ready;
+
+    /* Counters for Mir IDs to use */
+    int next_session_id;
+    int next_greeter_id;  
 };
 
 G_DEFINE_TYPE (UnitySystemCompositor, unity_system_compositor, DISPLAY_SERVER_TYPE);
@@ -172,17 +176,28 @@ static void
 unity_system_compositor_connect_session (DisplayServer *display_server, Session *session)
 {
     UnitySystemCompositor *compositor = UNITY_SYSTEM_COMPOSITOR (display_server);
-    const gchar *name;
 
     session_set_env (session, "XDG_SESSION_TYPE", "mir");
 
     if (compositor->priv->socket)
         session_set_env (session, "MIR_SERVER_HOST_SOCKET", compositor->priv->socket);
-    if (IS_GREETER_SESSION (session))
-        name = "greeter-0";
-    else
-        name = "session-0";
-    session_set_env (session, "MIR_SERVER_NAME", name);
+
+    if (!session_get_env (session, "MIR_SERVER_NAME"))
+    {
+        gchar *name;
+        if (IS_GREETER_SESSION (session))
+        {
+            name = g_strdup_printf ("greeter-%d", compositor->priv->next_greeter_id);
+            compositor->priv->next_greeter_id++;
+        }
+        else
+        {
+            name = g_strdup_printf ("session-%d", compositor->priv->next_session_id);
+            compositor->priv->next_session_id++;
+        }
+        session_set_env (session, "MIR_SERVER_NAME", name);
+        g_free (name);
+    }
 
     if (compositor->priv->vt >= 0)
     {
index 7f90c4e17c9291a271abd8ae8ce4f3ddbb794393..c8759ed6c97604c744bcfca71d29a37124d21880 100644 (file)
@@ -104,6 +104,12 @@ x_server_xmir_add_args (XServerLocal *x_server, GString *command)
         g_string_append_printf (command, " -mirSocket %s", server->priv->mir_socket);
 }
 
+static DisplayServer *
+x_server_xmir_get_parent (DisplayServer *server)
+{
+    return DISPLAY_SERVER (X_SERVER_XMIR (server)->priv->compositor);
+}
+
 static gint
 x_server_xmir_get_vt (DisplayServer *server)
 {
@@ -159,6 +165,7 @@ x_server_xmir_class_init (XServerXmirClass *klass)
     XServerLocalClass *x_server_local_class = X_SERVER_LOCAL_CLASS (klass);  
 
     x_server_local_class->add_args = x_server_xmir_add_args;
+    display_server_class->get_parent = x_server_xmir_get_parent;
     display_server_class->get_vt = x_server_xmir_get_vt;
     display_server_class->start = x_server_xmir_start;
     object_class->finalize = x_server_xmir_finalize;
index 39e2a81d640a0b230880f5d20bdd5e0f4169a86b..2d4c0b6365117c136616938463913be1e31334a2 100644 (file)
@@ -35,9 +35,7 @@ user-session=mir
 
 # Script hooks runs
 #?SCRIPT-HOOK SESSION-CLEANUP USER=have-password1
-# FIXME: order wrong here?
 #?SCRIPT-HOOK DISPLAY-SETUP
-#?SCRIPT-HOOK DISPLAY-STOPPED
 #?SCRIPT-HOOK GREETER-SETUP USER=.*
 
 # Greeter starts