fixed bug #34638: Dead code in tcp_receive - pcb->dupacks

diff --git a/CHANGELOG b/CHANGELOG
index f5f553cec5ed65e77a92a81382aed6c41e79b127..bbf809280dd4f4fa7b7d491431f8f06a34646597 100644 (file)
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -69,6 +69,9 @@ HISTORY
 
  ++ Bugfixes:
 
+  2011-10-28: Simon Goldschmidt
+  * tcp_in.c: fixed bug #34638: Dead code in tcp_receive - pcb->dupacks
+
   2011-10-23: Simon Goldschmidt
   * mem.c: fixed bug #34429: possible memory corruption with
     LWIP_ALLOW_MEM_FREE_FROM_OTHER_CONTEXT set to 1

diff --git a/src/core/tcp_in.c b/src/core/tcp_in.c
index b2d9db2ae6e590b7199a3b01e1b4a994bea037e6..0dd2c90477bfe593a1b1ce0b42635949e919a018 100644 (file)
--- a/src/core/tcp_in.c
+++ b/src/core/tcp_in.c
@@ -938,8 +938,9 @@ tcp_receive(struct tcp_pcb *pcb)
             /* Clause 5 */
             if (pcb->lastack == ackno) {
               found_dupack = 1;
-              if (pcb->dupacks + 1 > pcb->dupacks)
+              if ((u8_t)(pcb->dupacks + 1) > pcb->dupacks) {
                 ++pcb->dupacks;
+              }
               if (pcb->dupacks > 3) {
                 /* Inflate the congestion window, but not if it means that
                    the value overflows. */