]> rtime.felk.cvut.cz Git - pes-rpp/rpp-lwip.git/commitdiff
Sanity-check the size of netif->hwaddr
authorgoldsimon <goldsimon@gmx.de>
Mon, 13 Aug 2012 18:57:19 +0000 (20:57 +0200)
committergoldsimon <goldsimon@gmx.de>
Mon, 13 Aug 2012 18:57:19 +0000 (20:57 +0200)
src/core/dhcp.c

index 614fa324541f1b9d37c68c097f311c41a0ebd648..2851d712cda9794465bd30945eaef5eaf16009cc 100644 (file)
@@ -1693,7 +1693,7 @@ dhcp_create_msg(struct netif *netif, struct dhcp *dhcp, u8_t message_type)
   ip_addr_set_zero(&dhcp->msg_out->giaddr);
   for (i = 0; i < DHCP_CHADDR_LEN; i++) {
     /* copy netif hardware address, pad with zeroes */
-    dhcp->msg_out->chaddr[i] = (i < netif->hwaddr_len) ? netif->hwaddr[i] : 0/* pad byte*/;
+    dhcp->msg_out->chaddr[i] = (i < netif->hwaddr_len && i < NETIF_MAX_HWADDR_LEN) ? netif->hwaddr[i] : 0/* pad byte*/;
   }
   for (i = 0; i < DHCP_SNAME_LEN; i++) {
     dhcp->msg_out->sname[i] = 0;