Added a few comments. Cleaned coding style.

diff --git a/src/qemu/hw/mf624.c b/src/qemu/hw/mf624.c
index 67351d4ae555a5549e59e35b018c0c419c369eae..04c81a7c4bb129d520abd6d6ff9e264f65dbd8aa 100755 (executable)
--- a/src/qemu/hw/mf624.c
+++ b/src/qemu/hw/mf624.c
@@ -82,6 +82,7 @@ typedef struct {
        uint16_t DA7;
 } BAR2_t;
 
+/* Not implemented */
 typedef struct {
 //     uint32_t CTR0STATUS;
 //     uint32_t CTR0MODE;
@@ -99,7 +100,7 @@ typedef struct {
        int addr;
 
         /* The real voltage which is on inputs od A/D convertors.
-       Until new conversion is started, there is old value in ADC registers*/  
+       Until new conversion is started, there is still old value in ADC registers*/    
        unsigned int real_world_AD0; //Value in "ADC internal" format
        unsigned int real_world_AD1;
        unsigned int real_world_AD2;
@@ -119,10 +120,10 @@ typedef struct {
        BAR2_t BAR2;
        BAR4_t BAR4;
 
-       int ADDATA_FIFO[8];     //this array tells us which ADCs are being converted    
+       int ADDATA_FIFO[8]; //this array tells us which ADCs are being converted        
        unsigned int ADDATA_FIFO_POSITION; //ADDATA is FIFO register; 
-                                       //We need to know, position in this FIFO =
-                                       //Which value will come next
+                               //We need to know, position in this FIFO =
+                               //Which value will come next
 } mf624_state_t;
 
 int instance = 0; // Global variable shared between multiple mf624 devices
@@ -144,7 +145,10 @@ double dacinternal_to_volts(int16_t dacinternal)
 {
        return ((((double)dacinternal)/0x4000)*20.0 - 10.0);
 }
+
 //-----------------------------------------------------------------------------
+
+/* Initialize register values due to MF624 manual */
 void mf624_init_registers(mf624_state_t* s)
 {
 #define INTCSR_default_value           0x000300
@@ -177,7 +181,7 @@ void mf624_init_registers(mf624_state_t* s)
        s->ADDATA_FIFO_POSITION = 0;
 }
 
-
+/* After some widget's value is changed, new value is send via socket to Qemu */
 void socket_write(mf624_state_t *s, const char* reg, double val)
 {
        int status;
@@ -260,10 +264,9 @@ void* init_socket(void* ptr)
        struct sockaddr_in addr_srv;
        int port;
        int yes = 1;
-
        
        mf624_state_t* dev = (mf624_state_t*) ptr;
-       // If no client connected, we will know about it
+
        dev->socket_tmp = -1;
        port = dev->port;
 
@@ -325,6 +328,7 @@ void mf624_BAR0_write32(void *opaque, target_phys_addr_t addr, uint32_t value)
                        s->BAR0.INTCSR = (value & 0x7FF) | INTCSR_default_value; // Only first 11 bits are writable
                        socket_write(s, "INTCSR", s->BAR0.INTCSR);
                        break;
+                       
                case GPIOC_off:
                        //Don't write anywhere else than into these two bits
                        s->BAR0.GPIOC = (value & (GPIOC_LDAC_mask | GPIOC_DACEN_mask)) | GPIOC_default_value;
@@ -356,8 +360,8 @@ void mf624_BAR0_write32(void *opaque, target_phys_addr_t addr, uint32_t value)
                                socket_write(s, "DA6", dacinternal_to_volts(GND));
                                socket_write(s, "DA7", dacinternal_to_volts(GND));
                        }
-                               
                        break;
+                       
                default:
                        printf("mf624_BAR0_write32(): addr = %d; value = %d\n", addr, value);
                        break;
@@ -561,7 +565,6 @@ void mf624_BAR2_write16(void *opaque, target_phys_addr_t addr, uint32_t value)
                        printf("mf624_BAR2_write16(): addr = %d; value = %d\n", addr, value);
                        break;
        }
-
 }