]> rtime.felk.cvut.cz Git - lisovros/qemu_apohw.git/commitdiff
cpu: Document why cannot_instantiate_with_device_add_yet
authorMarkus Armbruster <armbru@redhat.com>
Thu, 28 Nov 2013 16:26:56 +0000 (17:26 +0100)
committerAndreas Färber <afaerber@suse.de>
Sun, 22 Dec 2013 23:27:22 +0000 (00:27 +0100)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Andreas Färber <afaerber@suse.de>
qom/cpu.c

index 09c15e6b6005a8c95cdacfdf00e5de6bc29d4878..9d624795461071bca72e6ea551fc71d298f846e4 100644 (file)
--- a/qom/cpu.c
+++ b/qom/cpu.c
@@ -254,7 +254,11 @@ static void cpu_class_init(ObjectClass *klass, void *data)
     k->gdb_read_register = cpu_common_gdb_read_register;
     k->gdb_write_register = cpu_common_gdb_write_register;
     dc->realize = cpu_common_realizefn;
-    dc->cannot_instantiate_with_device_add_yet = true; /* FIXME explain why */
+    /*
+     * Reason: CPUs still need special care by board code: wiring up
+     * IRQs, adding reset handlers, halting non-first CPUs, ...
+     */
+    dc->cannot_instantiate_with_device_add_yet = true;
 }
 
 static const TypeInfo cpu_type_info = {