]> rtime.felk.cvut.cz Git - lisovros/qemu_apohw.git/commitdiff
qemu-io: Don't print NULL when open without non-option arg fails
authorMarkus Armbruster <armbru@redhat.com>
Wed, 28 May 2014 09:17:00 +0000 (11:17 +0200)
committerKevin Wolf <kwolf@redhat.com>
Fri, 30 May 2014 12:26:54 +0000 (14:26 +0200)
Reproducer: "open -o a=b".  Broken in commit fd0fee3.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
qemu-io.c

index f63e771d9860ef6f513afdda5a4133875c5d50c2..795cf46c6e5c73ef8f112712fffb6d1ee31d1e2f 100644 (file)
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -62,7 +62,8 @@ static int openfile(char *name, int flags, int growable, QDict *opts)
         if (bdrv_open(&qemuio_bs, name, NULL, opts, flags | BDRV_O_PROTOCOL,
                       NULL, &local_err))
         {
-            fprintf(stderr, "%s: can't open device %s: %s\n", progname, name,
+            fprintf(stderr, "%s: can't open%s%s: %s\n", progname,
+                    name ? " device " : "", name ?: "",
                     error_get_pretty(local_err));
             error_free(local_err);
             return 1;
@@ -73,7 +74,8 @@ static int openfile(char *name, int flags, int growable, QDict *opts)
         if (bdrv_open(&qemuio_bs, name, NULL, opts, flags, NULL, &local_err)
             < 0)
         {
-            fprintf(stderr, "%s: can't open device %s: %s\n", progname, name,
+            fprintf(stderr, "%s: can't open%s%s: %s\n", progname,
+                    name ? " device " : "", name ?: "",
                     error_get_pretty(local_err));
             error_free(local_err);
             bdrv_unref(qemuio_bs);