]> rtime.felk.cvut.cz Git - lisovros/qemu_apohw.git/commitdiff
qapi: QMP input visitor, handle floats parsed as ints
authorMichael Roth <mdroth@linux.vnet.ibm.com>
Fri, 11 May 2012 17:43:24 +0000 (12:43 -0500)
committerLuiz Capitulino <lcapitulino@redhat.com>
Mon, 14 May 2012 13:08:39 +0000 (10:08 -0300)
JSON numbers can be interpreted as either integers or floating point
values depending on their representation. As a result, QMP input visitor
might visit a QInt when it was expecting a QFloat, so add handling to
account for this.

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Acked-by: Andreas Färber <afaerber@suse.de>
qapi/qmp-input-visitor.c

index 4cdc47dab5920f02b1ca2c1959ac502c91fff6f0..107d8d361b8c10bb8c671d2233d5638129d78c9e 100644 (file)
@@ -246,13 +246,18 @@ static void qmp_input_type_number(Visitor *v, double *obj, const char *name,
     QmpInputVisitor *qiv = to_qiv(v);
     QObject *qobj = qmp_input_get_object(qiv, name);
 
-    if (!qobj || qobject_type(qobj) != QTYPE_QFLOAT) {
+    if (!qobj || (qobject_type(qobj) != QTYPE_QFLOAT &&
+        qobject_type(qobj) != QTYPE_QINT)) {
         error_set(errp, QERR_INVALID_PARAMETER_TYPE, name ? name : "null",
-                  "double");
+                  "number");
         return;
     }
 
-    *obj = qfloat_get_double(qobject_to_qfloat(qobj));
+    if (qobject_type(qobj) == QTYPE_QINT) {
+        *obj = qint_get_int(qobject_to_qint(qobj));
+    } else {
+        *obj = qfloat_get_double(qobject_to_qfloat(qobj));
+    }
 }
 
 static void qmp_input_start_optional(Visitor *v, bool *present,