]> rtime.felk.cvut.cz Git - frescor/frsh-forb.git/commitdiff
fwp_fra.c: Initialized vparams.src.s_addr with 0 value
authorTuka Martin <tukamart@fel.cvut.cz>
Sun, 6 May 2012 18:36:53 +0000 (20:36 +0200)
committerTuka Martin <tukamart@fel.cvut.cz>
Sun, 6 May 2012 18:36:53 +0000 (20:36 +0200)
With no initialization there was a bad return value of
fwp_vres_set_params function

src/fwp/fwp/lib/frsh_fwp/fwp_fra.c

index 0f5f1ac726b8ebc5c87ec8993649315bb02f6ddf..6c9d85c4a4de4c6d154c2bbd5452c9ec4f455d46 100644 (file)
@@ -70,7 +70,7 @@ static int create_vres(fres_vres_t *vres, void *priv)
        int rv;
        size_t bytes;
        char src[21] = "N/A";
-       
+
        /* Prepare vres parameters */
        basic = fres_contract_get_basic(vres->new);
        fwp_sched = fres_contract_get_block(vres->new, FRES_BLOCK_FWP_SCHED);
@@ -78,7 +78,7 @@ static int create_vres(fres_vres_t *vres, void *priv)
                return FRES_ERR_NEEDS_MORE_DATA_IN_CONTRACT;
 
        fwp = fres_contract_get_block(vres->new, FRES_BLOCK_FWP);
-
+       
        frsh_network_budget_to_bytes(FRSH_NETPF_FWP, &basic->budget, &bytes);
        vparams.budget = bytes;
        vparams.period = basic->period;
@@ -86,6 +86,7 @@ static int create_vres(fres_vres_t *vres, void *priv)
        if (fwp) {
                vparams.src.s_addr = fwp->src;
                snprintf(src, sizeof(src), "%s", inet_ntoa(vparams.src));
+               ul_logmsg("Addr vparams.src.s_addr = %s\n", src);
        }
        /* Create vres */
        if ((rv = fwp_vres_create(&vparams, &fwp_vres)))
@@ -136,12 +137,12 @@ int change_vres(fres_vres_t *vres, void *priv)
        vparams.budget = bytes;
        vparams.period = basic->period;
        vparams.ac_id = fwp_sched->ac_id;
+       vparams.src.s_addr = 0;
        fwp_vres = vres->priv;
 
        /* Changing vres */
-       if ((rv = fwp_vres_set_params(fwp_vres, &vparams))) {
+       if ((rv = fwp_vres_set_params(fwp_vres, &vparams))) 
                return  rv;
-       }
 
        fres_contract_id_to_string(id, &vres->id, sizeof(id));
        printf("Changing FWP VRes (id=%s, period=%ld ms, budget=%ld bytes AC=%d)\n",