]> rtime.felk.cvut.cz Git - coffee/buildroot.git/commitdiff
busybox: disable PAM in the config if linux-pam is not selected
authorArnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Mon, 26 Mar 2018 12:00:06 +0000 (14:00 +0200)
committerPeter Korsgaard <peter@korsgaard.com>
Fri, 6 Apr 2018 17:57:45 +0000 (19:57 +0200)
Currently there is only logic to enable PAM when linux-pam is selected.
However, busybox will fail to build with PAM enabled if the linux-pam
package has not been built before. So we should forcibly disable PAM in
busybox in that case.

Normally this is not an issue since our default busybox config doesn't
have PAM enabled. However, if you enable linux-pam, then save the
busybox config to a custom configuration file, then disable linux-pam
again, and then do a "make clean; make", the build will fail. A more
practical situation where this can occur is when the same custom
busybox config is used in a Buildroot config with and without
linux-pam.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Reviewed-by: Matt Weber <matthew.weber@rockwellcollins.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
(cherry picked from commit 0876b023663377bc3a24c80399f447c1f2afe0c1)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
package/busybox/busybox.mk

index d0bbd3fd6ee682edad4dc1f4723f72fb67d693e2..f17c20bf543ae73b4e4882497a97e9f8762062dd 100644 (file)
@@ -248,6 +248,10 @@ define BUSYBOX_LINUX_PAM
        $(call KCONFIG_ENABLE_OPT,CONFIG_PAM,$(BUSYBOX_BUILD_CONFIG))
 endef
 BUSYBOX_DEPENDENCIES += linux-pam
+else
+define BUSYBOX_LINUX_PAM
+       $(call KCONFIG_DISABLE_OPT,CONFIG_PAM,$(BUSYBOX_BUILD_CONFIG))
+endef
 endif
 
 # Telnet support