package/transmission: remove BR2_PACKAGE_TRANSMISSION_REMOTE

Commit 6e223241e1bb58a27eb890291f9f5c1fcc6a0818 ("Add Transmission
package"), which added the transmission package, introduced a
BR2_PACKAGE_TRANSMISSION_REMOTE Config.in option, supposedly matching
the --enable-remote/--disable-remote transmission option.

However, transmission as of version 2.33 packaged by this initial
commit, did not have a --enable-remote/--disable-remote option, and it
was apparently never part of transmission.

Therefore, this commit removes this useless option. Since the
transmission-remote tool is automatically built when the daemon is
enabled, the Config.in.legacy handling selects
BR2_PACKAGE_TRANSMISSION_DAEMON.

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

diff --git a/Config.in.legacy b/Config.in.legacy
index 66d3a0c5a89b818ddda1f2fb99751b757985ba7a..1494704221798effd3823e1010aad712e633d43e 100644 (file)
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -145,6 +145,17 @@ endif
 ###############################################################################
 comment "Legacy options removed in 2018.05"
 
+config BR2_PACKAGE_TRANSMISSION_REMOTE
+       bool "transmission remote tool option removed"
+       select BR2_LEGACY
+       select BR2_PACKAGE_TRANSMISSION_DAEMON
+       help
+         Upstream does not provide a separate configure option for
+         the tool transmission-remote, it is built when the
+         transmission daemon has been enabled. Therefore, Buildroot
+         has automatically enabled BR2_PACKAGE_TRANSMISSION_DAEMON
+         for you.
+
 config BR2_PACKAGE_LIBKCAPI_APPS
        bool "libkcapi test applications removed"
        select BR2_LEGACY

diff --git a/package/transmission/Config.in b/package/transmission/Config.in
index 2110e52ac64654f47340a6afd70fb3e66b11a92c..dac4d1b3303c3168b7b03dcfebc4b571c00238ef 100644 (file)
--- a/package/transmission/Config.in
+++ b/package/transmission/Config.in
@@ -32,11 +32,6 @@ config BR2_PACKAGE_TRANSMISSION_DAEMON
        help
          Install transmission daemon.
 
-config BR2_PACKAGE_TRANSMISSION_REMOTE
-       bool "transmission-remote"
-       help
-         Install transmission remote management tool.
-
 config BR2_PACKAGE_TRANSMISSION_GTK
        bool "transmission-gtk"
        depends on BR2_PACKAGE_LIBGTK3 && BR2_SYSTEM_ENABLE_NLS

diff --git a/package/transmission/transmission.mk b/package/transmission/transmission.mk
index f10fa190c85c6df49f746802737f45b737246864..65add0d8c0385c736b18f98c49cbf7bec731be98 100644 (file)
--- a/package/transmission/transmission.mk
+++ b/package/transmission/transmission.mk
@@ -75,12 +75,6 @@ else
 TRANSMISSION_CONF_OPTS += --disable-daemon
 endif
 
-ifeq ($(BR2_PACKAGE_TRANSMISSION_REMOTE),y)
-TRANSMISSION_CONF_OPTS += --enable-remote
-else
-TRANSMISSION_CONF_OPTS += --disable-remote
-endif
-
 ifeq ($(BR2_PACKAGE_TRANSMISSION_GTK),y)
 TRANSMISSION_CONF_OPTS += --with-gtk
 TRANSMISSION_DEPENDENCIES += libgtk3