]> rtime.felk.cvut.cz Git - zynq/linux.git/commit
drm: xlnx: pl_disp: Fix error handling
authorHyun Kwon <hyun.kwon@xilinx.com>
Tue, 13 Feb 2018 17:33:45 +0000 (09:33 -0800)
committerMichal Simek <michal.simek@xilinx.com>
Thu, 1 Mar 2018 08:20:18 +0000 (09:20 +0100)
commitf5ea6df802d4a85f3a20e8c67ddf8e3e93268787
tree8a61e49d1264d895b4db20d2fb72f6259cec173d
parent4573cd8f1ad42113e23800033e32fc25d2efb807
drm: xlnx: pl_disp: Fix error handling

This fixes multiple error handling sequences. First, when component_add()
fails in probe, the requested dma channels should be released. Then,
in remove, the clean up sequence should be reverse order, thus, call
component_del() before dma channel release. Last, the all dma channels
should be release without checking the active flag, then use
dmaengine_terminate_sync() as dmaengine_terminate_all() is deprecated.

While at it, add a print on probe success.

Signed-off-by: Hyun Kwon <hyun.kwon@xilinx.com>
Tested-by: Saurabh Sengar <saurabhs@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
drivers/gpu/drm/xlnx/xlnx_pl_disp.c