]> rtime.felk.cvut.cz Git - zynq/linux.git/commit
USB: gadget: f_hid: fix deadlock in f_hidg_write()
authorAnurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>
Thu, 14 Mar 2019 11:45:20 +0000 (11:45 +0000)
committerMichal Simek <michal.simek@xilinx.com>
Fri, 15 Mar 2019 10:23:44 +0000 (11:23 +0100)
commite2443b5de98ae3c0dad4da8dff15fb6d02b95eb0
tree3e3694e09d018f923420d0f2ef50c76f7b35daae
parent793952469a4d37a0e1156a25c11760046d5e8ba3
USB: gadget: f_hid: fix deadlock in f_hidg_write()

In f_hidg_write() the write_spinlock is acquired before calling
usb_ep_queue() which causes a deadlock when dummy_hcd is being used.
This is because dummy_queue() callbacks into f_hidg_req_complete() which
tries to acquire the same spinlock. This is (part of) the backtrace when
the deadlock occurs:

  0xffffffffc06b1410 in f_hidg_req_complete
  0xffffffffc06a590a in usb_gadget_giveback_request
  0xffffffffc06cfff2 in dummy_queue
  0xffffffffc06a4b96 in usb_ep_queue
  0xffffffffc06b1eb6 in f_hidg_write
  0xffffffff8127730b in __vfs_write
  0xffffffff812774d1 in vfs_write
  0xffffffff81277725 in SYSC_write

Fix this by releasing the write_spinlock before calling usb_ep_queue()

Signed-off-by: Radoslav Gerganov <rgerganov@vmware.com>
Signed-off-by: Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
drivers/usb/gadget/function/f_hid.c