]> rtime.felk.cvut.cz Git - zynq/linux.git/commit
mm/tlb: Remove tlb_remove_table() non-concurrent condition
authorPeter Zijlstra <peterz@infradead.org>
Wed, 22 Aug 2018 15:30:14 +0000 (17:30 +0200)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 23 Aug 2018 18:55:58 +0000 (11:55 -0700)
commita6f572084fbee8b30f91465f4a085d7a90901c57
treeedfe14d7b24d0c54599e90ee493542be8a0411e9
parentdb7ddef301128dad394f1c0f77027f86ee9a4edb
mm/tlb: Remove tlb_remove_table() non-concurrent condition

Will noted that only checking mm_users is incorrect; we should also
check mm_count in order to cover CPUs that have a lazy reference to
this mm (and could do speculative TLB operations).

If removing this turns out to be a performance issue, we can
re-instate a more complete check, but in tlb_table_flush() eliding the
call_rcu_sched().

Fixes: 267239116987 ("mm, powerpc: move the RCU page-table freeing into generic code")
Reported-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Rik van Riel <riel@surriel.com>
Acked-by: Will Deacon <will.deacon@arm.com>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: David Miller <davem@davemloft.net>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/memory.c