]> rtime.felk.cvut.cz Git - zynq/linux.git/commit
spi: xlp: fix error return code in xlp_spi_probe()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 8 Aug 2017 04:45:02 +0000 (23:45 -0500)
committerMark Brown <broonie@kernel.org>
Tue, 8 Aug 2017 10:36:07 +0000 (11:36 +0100)
commit9a6b94796ae6feaf275ec6200e9b2964db208182
tree15be0a96b480bf376add9e5138d176c454d55f5e
parent5771a8c08880cdca3bfb4a3fc6d309d6bba20877
spi: xlp: fix error return code in xlp_spi_probe()

platform_get_irq() returns an error code, but the spi-xlp driver ignores
it and always returns -EINVAL. This is not correct and, prevents
-EPROBE_DEFER from being propagated properly.

Notice that platform_get_irq() no longer returns 0 on error:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af

Print and propagate the return value of platform_get_irq on failure.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-xlp.c