]> rtime.felk.cvut.cz Git - zynq/linux.git/commit
media: sir_ir: remove unnecessary static in sir_interrupt()
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Wed, 5 Jul 2017 18:16:04 +0000 (14:16 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Sun, 20 Aug 2017 13:41:43 +0000 (09:41 -0400)
commit6efa09436939ec10f966577f0f7fd706a8420693
treee6ffcda52d785c1e9790256fd0f98701af758991
parentb9e1486e0e4b5e0fc0cde214ceecec8a5734f620
media: sir_ir: remove unnecessary static in sir_interrupt()

Remove unnecessary static on local variable delt.
Such variable is initialized before being used,
on every execution path throughout the function.
The static has no benefit and, removing it reduces
the code size.

This issue was detected using Coccinelle and the following semantic patch:

@bad exists@
position p;
identifier x;
type T;
@@

static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@

-static
 T x@p;
 ... when != x
     when strict
?x = e;

In the following log you can see the difference in the code size. Also,
there is a significant difference in the bss segment. This log is the
output of the size command, before and after the code change:

before:
   text    data     bss     dec     hex filename
   5009    3456     576    9041    2351 drivers/media/rc/sir_ir.o

after:
   text    data     bss     dec     hex filename
   4988    3400     512    8900    22c4 drivers/media/rc/sir_ir.o

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/rc/sir_ir.c