]> rtime.felk.cvut.cz Git - zynq/linux.git/commit
platform/x86: msi-wmi: remove unnecessary static in msi_wmi_notify()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 18 Jul 2017 21:49:37 +0000 (16:49 -0500)
committerDarren Hart (VMware) <dvhart@infradead.org>
Tue, 25 Jul 2017 16:56:38 +0000 (09:56 -0700)
commit6d8d556262965bf7133b2540f293eaa1bc1e40d1
tree9cfb80dec0fb326565b5fea15bbc3f95ad1f05c8
parent890f658c101df5842ce8aaec1b0833cf1ba37eb3
platform/x86: msi-wmi: remove unnecessary static in msi_wmi_notify()

Remove unnecessary static on local variable _key_. Such variable is
initialized before being used, on every execution path throughout
the function. The static has no benefit and, removing it reduces
the object file size.

This issue was detected using Coccinelle and the following semantic patch:
https://github.com/GustavoARSilva/coccinelle/blob/master/static/static_unused.cocci

In the following log you can see a significant difference in the object
file size. Also, there is a significant difference in the bss segment.
This log is the output of the size command, before and after the code
change:

before:
   text    data     bss     dec     hex filename
   6530    3736     320   10586    295a drivers/platform/x86/msi-wmi.o

after:
   text    data     bss     dec     hex filename
   6494    3648     256   10398    289e drivers/platform/x86/msi-wmi.o

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/platform/x86/msi-wmi.c