]> rtime.felk.cvut.cz Git - zynq/linux.git/commit
sched: Do not clear PF_NO_SETAFFINITY flag in select_fallback_rq()
authorSteven Rostedt <rostedt@goodmis.org>
Tue, 1 Jul 2014 15:14:44 +0000 (11:14 -0400)
committerMichal Sojka <sojka@merica.cz>
Sun, 13 Sep 2015 07:47:46 +0000 (09:47 +0200)
commit43763c6e4013b5f3302b30c667ceb263c3c2b864
tree48a8302b5de57915c99d6799adde4d7d0aab5318
parent1530b259655021c94deab76a91efd63d2980c3da
sched: Do not clear PF_NO_SETAFFINITY flag in select_fallback_rq()

I talked with Peter Zijlstra about this, and he told me that the clearing
of the PF_NO_SETAFFINITY flag was to deal with the optimization of
migrate_disable/enable() that ignores tasks that have that flag set. But
that optimization was removed when I did a rework of the cpu hotplug code.

I found that ignoring tasks that had that flag set would cause those tasks
to not sync with the hotplug code and cause the kernel to crash. Thus it
needed to not treat them special and those tasks had to go though the same
work as tasks without that flag set.

Now that those tasks are not treated special, there's no reason to clear the
flag.

May still need to be tested as the migrate_me() code does not ignore those
flags.

Cc: stable-rt@vger.kernel.org
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Clark Williams <williams@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20140701111444.0cfebaa1@gandalf.local.home
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
kernel/sched/core.c