From 849e3dae644c7cdded997018066b044c174c0fa5 Mon Sep 17 00:00:00 2001 From: Deepak Nibade Date: Fri, 25 Jul 2014 12:35:45 +0530 Subject: [PATCH] misc: tegra-profiler: fix Coverity issue of NULL dereference Pointer "pt_regs *regs" is first dereferenced and then checked for NULL To fix this move NULL checking to beginning of function Coverity id : 26686 Bug 1416640 Change-Id: I40e97e38e5a61a5d77ea68fa511e996f24385cfc Signed-off-by: Deepak Nibade Reviewed-on: http://git-master/r/447532 (cherry picked from commit 4651be4faa111a0ff64a924889b69ec56ae19ace) Reviewed-on: http://git-master/r/454484 Reviewed-by: Igor Nabirushkin GVS: Gerrit_Virtual_Submit Tested-by: Maxim Morin Reviewed-by: Mitch Luban --- drivers/misc/tegra-profiler/eh_unwind.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/misc/tegra-profiler/eh_unwind.c b/drivers/misc/tegra-profiler/eh_unwind.c index 60ae9c440ad..2d6c6960e9f 100644 --- a/drivers/misc/tegra-profiler/eh_unwind.c +++ b/drivers/misc/tegra-profiler/eh_unwind.c @@ -1021,6 +1021,9 @@ quadd_get_user_callchain_ut(struct pt_regs *regs, struct ex_region_info ri; struct stackframe frame; + if (!regs || !mm) + return 0; + #ifdef CONFIG_ARM64 if (!compat_user_mode(regs)) { pr_warn_once("user_mode 64: unsupported\n"); @@ -1033,9 +1036,6 @@ quadd_get_user_callchain_ut(struct pt_regs *regs, cc->unw_rc = QUADD_URC_FAILURE; - if (!regs || !mm) - return 0; - if (nr_prev > 0) { ip = cc->curr_pc; sp = cc->curr_sp; -- 2.39.2