]> rtime.felk.cvut.cz Git - sojka/lightdm.git/blobdiff - src/login1.c
Load all users only when really needed
[sojka/lightdm.git] / src / login1.c
index 9e9ae87f98d0fd6bd794d834867eb4de9042889b..dc60a492a02a09557ba842d0809a71210103e330 100644 (file)
@@ -18,9 +18,6 @@
 #define LOGIN1_SERVICE_NAME "org.freedesktop.login1"
 #define LOGIN1_OBJECT_NAME "/org/freedesktop/login1"
 #define LOGIN1_MANAGER_INTERFACE_NAME "org.freedesktop.login1.Manager"
-#define DBUS_PROPERTIES_INTERFACE "org.freedesktop.DBus.Properties"
-#define DBUS_PROPERTIES_GET_METHOD "Get"
-#define LOGIN1_SEAT_INTERFACE "org.freedesktop.login1.Seat"
 
 enum {
     SEAT_ADDED,
@@ -49,7 +46,7 @@ enum {
     ACTIVE_SESSION_CHANGED,
     LAST_SEAT_SIGNAL
 };
-static guint seat_signals[LAST_SEAT_SIGNAL] = { 0, 0 };
+static guint seat_signals[LAST_SEAT_SIGNAL] = { 0 };
 
 struct Login1SeatPrivate
 {
@@ -85,30 +82,20 @@ login1_service_get_instance (void)
     return singleton;
 }
 
-static GVariant *
-seat_get_property (GDBusConnection *connection,
-                   Login1Seat *seat,
-                   const gchar *property_name)
+static void
+update_property (Login1Seat *seat, const gchar *name, GVariant *value)
 {
-    GVariant *result;
-    GError *error = NULL;
-
-    result = g_dbus_connection_call_sync (connection,
-                                          LOGIN1_SERVICE_NAME,
-                                          seat->priv->path,
-                                          DBUS_PROPERTIES_INTERFACE,
-                                          DBUS_PROPERTIES_GET_METHOD,
-                                          g_variant_new ("(ss)", LOGIN1_SEAT_INTERFACE, property_name),
-                                          G_VARIANT_TYPE ("(v)"),
-                                          G_DBUS_CALL_FLAGS_NONE,
-                                          -1,
-                                          NULL,
-                                          &error);
-    if (error)
-        g_warning ("Error updating %s: %s", property_name, error->message);
-    g_clear_error (&error);
-
-    return result;
+    if (strcmp (name, "CanGraphical") == 0 && g_variant_is_of_type (value, G_VARIANT_TYPE_BOOLEAN))
+    {
+        seat->priv->can_graphical = g_variant_get_boolean (value);
+        g_signal_emit (seat, seat_signals[CAN_GRAPHICAL_CHANGED], 0);
+    }
+    else if (strcmp (name, "ActiveSession") == 0 && g_variant_is_of_type (value, G_VARIANT_TYPE ("(so)")))
+    {
+        const gchar *login1_session_id;
+        g_variant_get (value, "(&so)", &login1_session_id, NULL);
+        g_signal_emit (seat, seat_signals[ACTIVE_SESSION_CHANGED], 0, login1_session_id);
+    }
 }
 
 static void
@@ -121,60 +108,40 @@ seat_properties_changed_cb (GDBusConnection *connection,
                             gpointer user_data)
 {
     Login1Seat *seat = user_data;
+    GVariantIter *iter;
     GVariantIter *invalidated_properties;
-    const gchar *property_name;
-
-    g_variant_get (parameters, "(sa{sv}as)", NULL, NULL, &invalidated_properties);
-    while (g_variant_iter_loop (invalidated_properties, "&s", &property_name))
+    const gchar *name;
+    GVariant *value;
+
+    g_variant_get (parameters, "(sa{sv}as)", NULL, &iter, &invalidated_properties);
+    while (g_variant_iter_loop (iter, "{&sv}", &name, &value))
+        update_property (seat, name, value);
+    g_variant_iter_free (iter);
+    while (g_variant_iter_loop (invalidated_properties, "&s", &name))
     {
-        if (strcmp (property_name, "CanGraphical") == 0)
-        {
-            GVariant *result;
-
-            result = seat_get_property (connection, seat, property_name);
-            if (result)
-            {
-                GVariant *value;
-
-                g_variant_get (result, "(v)", &value);
-                seat->priv->can_graphical = g_variant_get_boolean (value);
-                g_variant_unref (value);
-
-                g_signal_emit (seat, seat_signals[CAN_GRAPHICAL_CHANGED], 0);
+        GVariant *result;
+        GError *error = NULL;
 
-                g_variant_unref (result);
-            }
-        }
-        if (strcmp (property_name, "ActiveSession") == 0)
+        result = g_dbus_connection_call_sync (connection,
+                                              LOGIN1_SERVICE_NAME,
+                                              seat->priv->path,
+                                              "org.freedesktop.DBus.Properties",
+                                              "Get",
+                                              g_variant_new ("(ss)", "org.freedesktop.login1.Seat", name),
+                                              G_VARIANT_TYPE ("(v)"),
+                                              G_DBUS_CALL_FLAGS_NONE,
+                                              -1,
+                                              NULL,
+                                              &error);
+        if (error)
+            g_warning ("Error updating seat property %s: %s", name, error->message);
+        g_clear_error (&error);
+        if (result)
         {
-            GVariant *result;
-
-            result = seat_get_property (connection, seat, property_name);
-            if (result)
-            {
-                GVariant *value1, *value2;
-                const gchar *login1_session;
-
-                g_variant_get (result, "(v)", &value1);
-
-                // returned value should be of type (so)
-                value2 = g_variant_get_child_value (value1, 0);
-
-                if (value2)
-                {
-                    login1_session = g_variant_get_string (value2, NULL);
-
-                    if (login1_session)
-                    {
-                        g_signal_emit (seat, seat_signals[ACTIVE_SESSION_CHANGED], 0, login1_session);
-                    }
-
-                    g_variant_unref (value2);
-                }
-
-                g_variant_unref (value1);
-                g_variant_unref (result);
-            }
+            g_variant_get (result, "(v)", &value);
+            update_property (seat, name, value);
+            g_variant_unref (value);
+            g_variant_unref (result);
         }
     }
     g_variant_iter_free (invalidated_properties);
@@ -483,7 +450,7 @@ login1_service_finalize (GObject *object)
 
     g_list_free_full (self->priv->seats, g_object_unref);
     g_dbus_connection_signal_unsubscribe (self->priv->connection, self->priv->signal_id);
-    g_object_unref (self->priv->connection);
+    g_clear_object (&self->priv->connection);
 
     G_OBJECT_CLASS (login1_service_parent_class)->finalize (object);
 }
@@ -498,7 +465,7 @@ login1_service_class_init (Login1ServiceClass *klass)
     g_type_class_add_private (klass, sizeof (Login1ServicePrivate));
 
     service_signals[SEAT_ADDED] =
-        g_signal_new ("seat-added",
+        g_signal_new (LOGIN1_SERVICE_SIGNAL_SEAT_ADDED,
                       G_TYPE_FROM_CLASS (klass),
                       G_SIGNAL_RUN_LAST,
                       G_STRUCT_OFFSET (Login1ServiceClass, seat_added),
@@ -506,7 +473,7 @@ login1_service_class_init (Login1ServiceClass *klass)
                       NULL,
                       G_TYPE_NONE, 1, LOGIN1_SEAT_TYPE);
     service_signals[SEAT_REMOVED] =
-        g_signal_new ("seat-removed",
+        g_signal_new (LOGIN1_SERVICE_SIGNAL_SEAT_REMOVED,
                       G_TYPE_FROM_CLASS (klass),
                       G_SIGNAL_RUN_LAST,
                       G_STRUCT_OFFSET (Login1ServiceClass, seat_removed),
@@ -565,7 +532,7 @@ login1_seat_class_init (Login1SeatClass *klass)
     g_type_class_add_private (klass, sizeof (Login1SeatPrivate));
 
     seat_signals[CAN_GRAPHICAL_CHANGED] =
-        g_signal_new (SIGNAL_LOGIN1_CAN_GRAPHICAL_CHANGED,
+        g_signal_new (LOGIN1_SEAT_SIGNAL_CAN_GRAPHICAL_CHANGED,
                       G_TYPE_FROM_CLASS (klass),
                       G_SIGNAL_RUN_LAST,
                       G_STRUCT_OFFSET (Login1SeatClass, can_graphical_changed),
@@ -574,7 +541,7 @@ login1_seat_class_init (Login1SeatClass *klass)
                       G_TYPE_NONE, 0);
 
     seat_signals[ACTIVE_SESSION_CHANGED] =
-        g_signal_new (SIGNAL_LOGIN1_ACTIVE_SESION_CHANGED,
+        g_signal_new (LOGIN1_SIGNAL_ACTIVE_SESION_CHANGED,
                       G_TYPE_FROM_CLASS (klass),
                       G_SIGNAL_RUN_LAST,
                       G_STRUCT_OFFSET (Login1SeatClass, active_session_changed),